update some of the unit tests

Author: yut-code

backend/tests/unit/test_intake_form_processor.py

@@ -167,7 +167,7 @@ def test_participant_with_cancer_only(db_session, test_user):
                 "treatments": ["Chemotherapy", "Transfusions"],
                 "experiences": ["Anxiety", "Fatigue"],
             },
-            "additional_info": "I have specific dietary restrictions and prefer morning appointments.",
+            "additional_info": "    I have specific dietary restrictions and prefer morning appointments.",
         }
 
         # Act
@@ -198,7 +198,7 @@ def test_participant_with_cancer_only(db_session, test_user):
         assert user_data.caring_for_someone == "no"
 
         # Assert - Additional Info
-        assert user_data.additional_info == "   I have specific dietary restrictions and prefer morning appointments."
+        assert user_data.additional_info == "I have specific dietary restrictions and prefer morning appointments."
 
         # Assert - Treatments (many-to-many)
         treatment_names = [t.name for t in user_data.treatments]
@@ -256,7 +256,7 @@ def test_volunteer_caregiver_experience_processing(db_session, test_user):
             "caregiver_experience": {
                 "experiences": ["Anxiety", "Depression"],
             },
-            "additional_info": "I have experience with elderly care and can provide emotional support.",
+            "additional_info": "I have experience with elderly care and can provide emotional support. I have special requirements  \n\t",
             "loved_one": {
                 "demographics": {"gender_identity": "Male", "age": "45-54"},
                 "cancer_experience": {
@@ -291,7 +291,7 @@ def test_volunteer_caregiver_experience_processing(db_session, test_user):
         assert "Depression" in experience_names
 
         # Assert - Additional Info
-        assert user_data.additional_info == "I have experience with elderly care and can provide emotional support."
+        assert user_data.additional_info == "I have experience with elderly care and can provide emotional support. I have special requirements"
 
         # Assert - No personal cancer experience
         assert user_data.diagnosis is None
@@ -365,6 +365,7 @@ def test_form_submission_json_structure(db_session, test_user):
                     "experiences": ["Brain Fog", "Feeling Overwhelmed"],
                 },
             },
+            "additional_info": "I'm only free on weekdays.",
         }
 
         # Act
@@ -388,6 +389,8 @@ def test_form_submission_json_structure(db_session, test_user):
         assert len(user_data.loved_one_treatments) >= 2  # Radiation + Palliative
         assert len(user_data.loved_one_experiences) >= 2  # Brain Fog + Feeling Overwhelmed
 
+        assert user_data.additional_info == "I'm only free on weekdays."
+
         db_session.refresh(test_user)
         assert test_user.form_status == FormStatus.INTAKE_SUBMITTED
 
@@ -423,6 +426,7 @@ def test_empty_and_minimal_data_handling(db_session, test_user):
                 "marital_status": "",  # Empty string
                 "has_kids": "",
             },
+            "additional_info": "",
             # No cancer_experience, caregiver_experience, or loved_one sections
         }
 
@@ -447,6 +451,8 @@ def test_empty_and_minimal_data_handling(db_session, test_user):
         assert len(user_data.experiences) == 0
         assert user_data.loved_one_gender_identity is None
 
+        assert user_data.additional_info == ""
+
         db_session.refresh(test_user)
         assert test_user.form_status == FormStatus.INTAKE_SUBMITTED
 
@@ -491,6 +497,7 @@ def test_participant_caregiver_without_cancer(db_session, test_user):
                     "experiences": ["Anxiety", "Communication Challenges"],
                 },
             },
+            "additional_info": "I need to be in the same city as the loved one",
         }
 
         # Act
@@ -528,6 +535,8 @@ def test_participant_caregiver_without_cancer(db_session, test_user):
         assert "Anxiety" in loved_one_experience_names
         assert "Communication Challenges" in loved_one_experience_names
 
+        assert user_data.additional_info == "I need to be in the same city as the loved one"
+
         db_session.commit()
 
     except Exception:
@@ -612,6 +621,8 @@ def test_participant_cancer_patient_and_caregiver(db_session, test_user):
         # Assert - Custom demographics
         assert "Other" in user_data.ethnic_group
         assert user_data.other_ethnic_group == "Mixed European heritage"
+        
+        assert user_data.additional_info is None
 
         db_session.commit()
 
@@ -680,6 +691,8 @@ def test_participant_no_cancer_experience(db_session, test_user):
         assert len(user_data.loved_one_treatments) == 0
         assert len(user_data.loved_one_experiences) == 0
 
+        assert user_data.additional_info is None
+
         db_session.commit()
 
     except Exception:
@@ -749,6 +762,8 @@ def test_volunteer_cancer_patient_only(db_session, test_user):
         assert len(user_data.loved_one_treatments) == 0
         assert len(user_data.loved_one_experiences) == 0
 
+        assert user_data.additional_info is None
+
         db_session.commit()
 
     except Exception:
@@ -796,6 +811,7 @@ def test_volunteer_cancer_patient_and_caregiver(db_session, test_user):
                     "experiences": ["Brain Fog", "Fatigue"],
                 },
             },
+            "additional_info": "N/A",
         }
 
         # Act
@@ -826,6 +842,8 @@ def test_volunteer_cancer_patient_and_caregiver(db_session, test_user):
         assert len(user_data.loved_one_treatments) >= 2
         assert len(user_data.loved_one_experiences) >= 2
 
+        assert user_data.additional_info == "N/A"
+
         db_session.commit()
 
     except Exception:
@@ -892,6 +910,8 @@ def test_volunteer_no_cancer_experience(db_session, test_user):
         assert len(user_data.loved_one_treatments) == 0
         assert len(user_data.loved_one_experiences) == 0
 
+        assert user_data.additional_info is None
+
         db_session.commit()
 
     except Exception:
@@ -1187,6 +1207,7 @@ def test_unicode_and_special_characters(db_session, test_user):
                 "treatments": ["Chimiothérapie"],
                 "experiences": ["Fatigue"],
             },
+            "additional_info": "émojis 🎉, unicode 中文, and various symbols @#$%^&*()",
         }
 
         user_data = processor.process_form_submission(str(test_user.id), form_data)
@@ -1200,6 +1221,8 @@ def test_unicode_and_special_characters(db_session, test_user):
         assert "हिन्दी" in user_data.other_ethnic_group
         assert "🌍" in user_data.other_ethnic_group
 
+        assert user_data.additional_info == "émojis 🎉, unicode 中文, and various symbols @#$%^&*()"
+
         db_session.commit()
 
     except Exception:
@@ -1245,116 +1268,3 @@ def test_boundary_date_values(db_session, test_user):
     except Exception:
         db_session.rollback()
         raise
-
-
-# def test_additional_info_field_processing(db_session, test_user):
-#     """Test processing of additional_info field with various scenarios"""
-#     try:
-#         processor = IntakeFormProcessor(db_session)
-
-#         # Test 1: Normal additional info
-#         form_data_with_info = {
-#             "form_type": "participant",
-#             "has_blood_cancer": "yes",
-#             "caring_for_someone": "no",
-#             "personal_info": {
-#                 "first_name": "Test",
-#                 "last_name": "User",
-#                 "date_of_birth": "01/01/1990",
-#                 "phone_number": "555-1234",
-#                 "city": "Toronto",
-#                 "province": "Ontario",
-#                 "postal_code": "M5V 3A1",
-#             },
-#             "additional_info": "I have specific dietary needs and prefer afternoon appointments.",
-#         }
-
-#         user_data = processor.process_form_submission(str(test_user.id), form_data_with_info)
-#         assert user_data.additional_info == "I have specific dietary needs and prefer afternoon appointments."
-
-#         # Test 2: Empty additional info
-#         form_data_empty = {
-#             "form_type": "participant",
-#             "has_blood_cancer": "no",
-#             "caring_for_someone": "no",
-#             "personal_info": {
-#                 "first_name": "Test",
-#                 "last_name": "User2",
-#                 "date_of_birth": "01/01/1990",
-#                 "phone_number": "555-1234",
-#                 "city": "Toronto",
-#                 "province": "Ontario",
-#                 "postal_code": "M5V 3A1",
-#             },
-#             "additional_info": "",
-#         }
-
-#         user_data_empty = processor.process_form_submission(str(test_user.id), form_data_empty)
-#         assert user_data_empty.additional_info == ""
-
-#         # Test 3: Additional info with whitespace (should be trimmed)
-#         form_data_whitespace = {
-#             "form_type": "participant",
-#             "has_blood_cancer": "no",
-#             "caring_for_someone": "no",
-#             "personal_info": {
-#                 "first_name": "Test",
-#                 "last_name": "User3",
-#                 "date_of_birth": "01/01/1990",
-#                 "phone_number": "555-1234",
-#                 "city": "Toronto",
-#                 "province": "Ontario",
-#                 "postal_code": "M5V 3A1",
-#             },
-#             "additional_info": "  I have special requirements  \n\t",
-#         }
-
-#         user_data_whitespace = processor.process_form_submission(str(test_user.id), form_data_whitespace)
-#         assert user_data_whitespace.additional_info == "I have special requirements"
-
-#         # Test 4: No additional_info field (should be None)
-#         form_data_no_field = {
-#             "form_type": "participant",
-#             "has_blood_cancer": "no",
-#             "caring_for_someone": "no",
-#             "personal_info": {
-#                 "first_name": "Test",
-#                 "last_name": "User4",
-#                 "date_of_birth": "01/01/1990",
-#                 "phone_number": "555-1234",
-#                 "city": "Toronto",
-#                 "province": "Ontario",
-#                 "postal_code": "M5V 3A1",
-#             },
-#             # No additional_info field
-#         }
-
-#         user_data_no_field = processor.process_form_submission(str(test_user.id), form_data_no_field)
-#         assert user_data_no_field.additional_info is None
-
-#         # Test 5: Long additional info with special characters
-#         long_text = "This is a very long additional information field that contains special characters: émojis 🎉, unicode 中文, and various symbols @#$%^&*(). It should be stored correctly without any issues."
-#         form_data_long = {
-#             "form_type": "participant",
-#             "has_blood_cancer": "no",
-#             "caring_for_someone": "no",
-#             "personal_info": {
-#                 "first_name": "Test",
-#                 "last_name": "User5",
-#                 "date_of_birth": "01/01/1990",
-#                 "phone_number": "555-1234",
-#                 "city": "Toronto",
-#                 "province": "Ontario",
-#                 "postal_code": "M5V 3A1",
-#             },
-#             "additional_info": long_text,
-#         }
-
-#         user_data_long = processor.process_form_submission(str(test_user.id), form_data_long)
-#         assert user_data_long.additional_info == long_text
-
-#         db_session.commit()
-
-#     except Exception:
-#         db_session.rollback()
-#         raise