linting

Author: richieb21

backend/migrations/versions/ded0314bce37_create_tasks_table.py

@@ -5,22 +5,25 @@
 Create Date: 2025-09-29 19:52:52.161683
 
 """
+
 from typing import Sequence, Union
 
 import sqlalchemy as sa
 from alembic import op
 from sqlalchemy.dialects import postgresql
 
 # revision identifiers, used by Alembic.
-revision: str = 'ded0314bce37'
-down_revision: Union[str, None] = 'seed_intake_forms'
+revision: str = "ded0314bce37"
+down_revision: Union[str, None] = "seed_intake_forms"
 branch_labels: Union[str, Sequence[str], None] = None
 depends_on: Union[str, Sequence[str], None] = None
 
 
 def upgrade() -> None:
     # Create task_type enum
-    op.execute("CREATE TYPE task_type AS ENUM ('intake_form_review', 'volunteer_app_review', 'profile_update', 'matching')")
+    op.execute(
+        "CREATE TYPE task_type AS ENUM ('intake_form_review', 'volunteer_app_review', 'profile_update', 'matching')"
+    )
 
     # Create task_priority enum
     op.execute("CREATE TYPE task_priority AS ENUM ('low', 'medium', 'high', 'no_status')")
@@ -30,41 +33,57 @@ def upgrade() -> None:
 
     # Create tasks table
     op.create_table(
-        'tasks',
-        sa.Column('id', sa.UUID(), nullable=False),
-        sa.Column('participant_id', sa.UUID(), nullable=False),
-        sa.Column('type', postgresql.ENUM('intake_form_review', 'volunteer_app_review', 'profile_update', 'matching', name='task_type'), nullable=False),
-        sa.Column('priority', postgresql.ENUM('low', 'medium', 'high', 'no_status', name='task_priority'), nullable=False, server_default='no_status'),
-        sa.Column('assignee_id', sa.UUID(), nullable=True),
-        sa.Column('start_date', sa.DateTime(timezone=True), nullable=False, server_default=sa.text('now()')),
-        sa.Column('end_date', sa.DateTime(timezone=True), nullable=True),
-        sa.Column('status', postgresql.ENUM('pending', 'in_progress', 'completed', name='task_status'), nullable=False, server_default='pending'),
-        sa.Column('task_metadata', postgresql.JSONB(astext_type=sa.Text()), nullable=True),
-        sa.Column('created_at', sa.DateTime(timezone=True), nullable=False, server_default=sa.text('now()')),
-        sa.Column('updated_at', sa.DateTime(timezone=True), nullable=False, server_default=sa.text('now()')),
-        sa.ForeignKeyConstraint(['assignee_id'], ['users.id'], ondelete='SET NULL'),
-        sa.ForeignKeyConstraint(['participant_id'], ['users.id'], ondelete='CASCADE'),
-        sa.PrimaryKeyConstraint('id')
+        "tasks",
+        sa.Column("id", sa.UUID(), nullable=False),
+        sa.Column("participant_id", sa.UUID(), nullable=False),
+        sa.Column(
+            "type",
+            postgresql.ENUM(
+                "intake_form_review", "volunteer_app_review", "profile_update", "matching", name="task_type"
+            ),
+            nullable=False,
+        ),
+        sa.Column(
+            "priority",
+            postgresql.ENUM("low", "medium", "high", "no_status", name="task_priority"),
+            nullable=False,
+            server_default="no_status",
+        ),
+        sa.Column("assignee_id", sa.UUID(), nullable=True),
+        sa.Column("start_date", sa.DateTime(timezone=True), nullable=False, server_default=sa.text("now()")),
+        sa.Column("end_date", sa.DateTime(timezone=True), nullable=True),
+        sa.Column(
+            "status",
+            postgresql.ENUM("pending", "in_progress", "completed", name="task_status"),
+            nullable=False,
+            server_default="pending",
+        ),
+        sa.Column("task_metadata", postgresql.JSONB(astext_type=sa.Text()), nullable=True),
+        sa.Column("created_at", sa.DateTime(timezone=True), nullable=False, server_default=sa.text("now()")),
+        sa.Column("updated_at", sa.DateTime(timezone=True), nullable=False, server_default=sa.text("now()")),
+        sa.ForeignKeyConstraint(["assignee_id"], ["users.id"], ondelete="SET NULL"),
+        sa.ForeignKeyConstraint(["participant_id"], ["users.id"], ondelete="CASCADE"),
+        sa.PrimaryKeyConstraint("id"),
     )
 
     # Create indexes for common queries
-    op.create_index('ix_tasks_participant_id', 'tasks', ['participant_id'])
-    op.create_index('ix_tasks_assignee_id', 'tasks', ['assignee_id'])
-    op.create_index('ix_tasks_type', 'tasks', ['type'])
-    op.create_index('ix_tasks_status', 'tasks', ['status'])
-    op.create_index('ix_tasks_priority', 'tasks', ['priority'])
+    op.create_index("ix_tasks_participant_id", "tasks", ["participant_id"])
+    op.create_index("ix_tasks_assignee_id", "tasks", ["assignee_id"])
+    op.create_index("ix_tasks_type", "tasks", ["type"])
+    op.create_index("ix_tasks_status", "tasks", ["status"])
+    op.create_index("ix_tasks_priority", "tasks", ["priority"])
 
 
 def downgrade() -> None:
     # Drop indexes
-    op.drop_index('ix_tasks_priority', table_name='tasks')
-    op.drop_index('ix_tasks_status', table_name='tasks')
-    op.drop_index('ix_tasks_type', table_name='tasks')
-    op.drop_index('ix_tasks_assignee_id', table_name='tasks')
-    op.drop_index('ix_tasks_participant_id', table_name='tasks')
+    op.drop_index("ix_tasks_priority", table_name="tasks")
+    op.drop_index("ix_tasks_status", table_name="tasks")
+    op.drop_index("ix_tasks_type", table_name="tasks")
+    op.drop_index("ix_tasks_assignee_id", table_name="tasks")
+    op.drop_index("ix_tasks_participant_id", table_name="tasks")
 
     # Drop tasks table
-    op.drop_table('tasks')
+    op.drop_table("tasks")
 
     # Drop enums
     op.execute("DROP TYPE task_status")

backend/migrations/versions/seed_intake_forms.py

@@ -5,22 +5,24 @@
 Create Date: 2025-06-29 15:30:00.000000
 
 """
+
 import uuid
 from typing import Sequence, Union
 
 import sqlalchemy as sa
 from alembic import op
 
 # revision identifiers, used by Alembic.
-revision: str = 'seed_intake_forms'
-down_revision: Union[str, None] = 'f11846c50673'
+revision: str = "seed_intake_forms"
+down_revision: Union[str, None] = "f11846c50673"
 branch_labels: Union[str, Sequence[str], None] = None
 depends_on: Union[str, Sequence[str], None] = None
 
 # Generate static UUIDs for forms to ensure consistency
 PARTICIPANT_FORM_ID = uuid.uuid4()
 VOLUNTEER_FORM_ID = uuid.uuid4()
 
+
 def upgrade() -> None:
     op.bulk_insert(
         sa.table(
@@ -31,20 +33,11 @@ def upgrade() -> None:
             sa.Column("type", sa.String(), nullable=False),
         ),
         [
-            {
-                "id": PARTICIPANT_FORM_ID,
-                "name": "Participant Intake Form",
-                "version": 1,
-                "type": "intake"
-            },
-            {
-                "id": VOLUNTEER_FORM_ID,
-                "name": "Volunteer Intake Form",
-                "version": 1,
-                "type": "intake"
-            }
+            {"id": PARTICIPANT_FORM_ID, "name": "Participant Intake Form", "version": 1, "type": "intake"},
+            {"id": VOLUNTEER_FORM_ID, "name": "Volunteer Intake Form", "version": 1, "type": "intake"},
         ],
     )
 
+
 def downgrade() -> None:
     op.execute(f"DELETE FROM forms WHERE id IN ('{PARTICIPANT_FORM_ID}', '{VOLUNTEER_FORM_ID}')")

backend/tests/conftest.py

@@ -12,6 +12,7 @@
 # Use in-memory SQLite for tests
 SQLALCHEMY_DATABASE_URL = "sqlite://"
 
+
 @pytest.fixture(scope="session")
 def test_engine():
     """Create a test database engine"""
@@ -23,6 +24,7 @@ def test_engine():
     Base.metadata.create_all(bind=engine)
     return engine
 
+
 @pytest.fixture(scope="function")
 def db_session(test_engine):
     """Create a fresh database session for each test"""
@@ -34,9 +36,11 @@ def db_session(test_engine):
         db.rollback()
         db.close()
 
+
 @pytest.fixture(scope="function")
 def client(db_session):
     """Create a test client with a test database"""
+
     def override_get_db():
         try:
             yield db_session
@@ -48,12 +52,14 @@ def override_get_db():
         yield test_client
     app.dependency_overrides.clear()
 
+
 @pytest.fixture(scope="function")
 def auth_headers():
     """Mock authentication headers for testing"""
     # This is a mock token - in real tests you might want to use a real Firebase token
     return {"Authorization": "Bearer test-token"}
 
+
 @pytest.fixture(scope="function")
 def mock_auth_middleware(monkeypatch):
     """Mock the auth middleware to bypass Firebase authentication"""

backend/tests/fixtures/models.py

@@ -21,24 +21,21 @@ def create_test_user(db, role_name="participant"):
         email="[email protected]",
         role_id=role.id,
         auth_id="test-user-id",
-        approved=True
+        approved=True,
     )
     db.add(user)
     db.flush()
     return user
 
+
 def create_test_form(db):
     """Create a test intake form"""
-    form = Form(
-        id=uuid.uuid4(),
-        name="Test Intake Form",
-        version=1,
-        type="intake"
-    )
+    form = Form(id=uuid.uuid4(), name="Test Intake Form", version=1, type="intake")
     db.add(form)
     db.flush()
     return form
 
+
 def create_test_submission(db, user=None, form=None):
     """Create a test form submission"""
     if not user:
@@ -51,10 +48,7 @@ def create_test_submission(db, user=None, form=None):
         form_id=form.id,
         user_id=user.id,
         submitted_at=datetime.utcnow(),
-        answers={
-            "test_field": "test value",
-            "another_field": 123
-        }
+        answers={"test_field": "test value", "another_field": 123},
     )
     db.add(submission)
     db.flush()

backend/tests/unit/routes/test_intake.py

@@ -20,20 +20,15 @@ def test_list_forms(client, db_session, mock_auth_middleware):
     assert forms[0]["name"] == form.name
     assert forms[0]["type"] == "intake"
 
+
 def test_create_submission(client, db_session, mock_auth_middleware):
     """Test POST /intake/submissions endpoint"""
     # Create test user and form
     form = create_test_form(db_session)
     db_session.commit()
 
     # Prepare submission data
-    submission_data = {
-        "form_id": str(form.id),
-        "answers": {
-            "test_question": "test answer",
-            "numeric_question": 42
-        }
-    }
+    submission_data = {"form_id": str(form.id), "answers": {"test_question": "test answer", "numeric_question": 42}}
 
     # Make request
     response = client.post("/intake/submissions", json=submission_data)
@@ -44,6 +39,7 @@ def test_create_submission(client, db_session, mock_auth_middleware):
     assert data["form_id"] == str(form.id)
     assert data["answers"] == submission_data["answers"]
 
+
 def test_get_own_submissions(client, db_session, mock_auth_middleware):
     """Test GET /intake/submissions endpoint - user can see their own submissions"""
     # Create test data
@@ -61,6 +57,7 @@ def test_get_own_submissions(client, db_session, mock_auth_middleware):
     assert len(data["submissions"]) == 1
     assert data["submissions"][0]["id"] == str(submission.id)
 
+
 def test_update_submission(client, db_session, mock_auth_middleware):
     """Test PUT /intake/submissions/{submission_id} endpoint"""
     # Create test data
@@ -69,24 +66,17 @@ def test_update_submission(client, db_session, mock_auth_middleware):
     db_session.commit()
 
     # Prepare update data
-    update_data = {
-        "answers": {
-            "updated_field": "updated value",
-            "another_field": 456
-        }
-    }
+    update_data = {"answers": {"updated_field": "updated value", "another_field": 456}}
 
     # Make request
-    response = client.put(
-        f"/intake/submissions/{submission.id}",
-        json=update_data
-    )
+    response = client.put(f"/intake/submissions/{submission.id}", json=update_data)
 
     # Check response
     assert response.status_code == status.HTTP_200_OK
     data = response.json()
     assert data["answers"] == update_data["answers"]
 
+
 def test_delete_submission(client, db_session, mock_auth_middleware):
     """Test DELETE /intake/submissions/{submission_id} endpoint"""
     # Create test data