Merged
Conversation
3405840 to
0f04d27
Compare
…ord doesn't pass validation
YashK2005
approved these changes
Sep 26, 2025
Collaborator
YashK2005
left a comment
There was a problem hiding this comment.
Great work, this is much better than what we had before!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion ticket link
No link
Implementation description
The backend user schema was modified to return an array of requirements that the password does not meet rather than just raising the first one, with updated requirements as well. The authApiClient was modified to handle 422 errors and parse this list of errors. The participant form frontend was modified check if there is an error before running
router.push(), and to loop over the errors to display the requirement list. In the future we can make this change to admin page as well.Steps to test
On the registration page enter a password which does not fit the requirements. Instead of allowing you to proceed, it should show a checklist of requirements the password must meet. This should match the figma design: https://www.figma.com/design/HhFPmxFewSCBLGkIt9RZen/LLSC-Main-Design-File?node-id=6082-14924&t=xlyQNnm2i6cO0ct6-0
What it looks like
Backend tests
Tests in

user_schema_test.pyhandle password requirement logic and all of them should passWhat should reviewers focus on?
Checklist