Skip to content

Tyu/f25/eligibility checklist#71

Merged
yut-code merged 2 commits intomainfrom
tyu/f25/eligibility-checklist
Nov 25, 2025
Merged

Tyu/f25/eligibility checklist#71
yut-code merged 2 commits intomainfrom
tyu/f25/eligibility-checklist

Conversation

@yut-code
Copy link
Collaborator

@yut-code yut-code commented Nov 11, 2025

Notion ticket link

Add Eligibility Criteria Section to Volunteer Intake Form

Implementation description

  • Instead of a radio button prompting the user to select whether they have a criminal record (and redirecting when they select yes), a list of checkboxes are displayed
  • All boxes must be checked to submit

Steps to test

1.Go to intake form and check for validity

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@yut-code yut-code marked this pull request as ready for review November 25, 2025 01:40
@yut-code yut-code requested a review from YashK2005 November 25, 2025 01:40
Copy link
Collaborator

@YashK2005 YashK2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yut-code yut-code merged commit ff283d6 into main Nov 25, 2025
1 check passed
@yut-code yut-code deleted the tyu/f25/eligibility-checklist branch November 25, 2025 01:50
UmairHundekar pushed a commit that referenced this pull request Nov 25, 2025
## Notion ticket link
<!-- Please replace with your ticket's URL -->
[Add Eligibility Criteria Section to Volunteer Intake
Form](https://www.notion.so/Add-Eligibility-Criteria-Section-to-Volunteer-Intake-Form-2a710f3fb1dc802c85d7fe4f9ea56bde?source=copy_link)


<!-- Give a quick summary of the implementation details, provide design
justifications if necessary -->
## Implementation description
* Instead of a radio button prompting the user to select whether they
have a criminal record (and redirecting when they select yes), a list of
checkboxes are displayed
* All boxes must be checked to submit
* 


<!-- What should the reviewer do to verify your changes? Describe
expected results and include screenshots when appropriate -->
## Steps to test
1.Go to intake form and check for validity


<!-- Draw attention to the substantial parts of your PR or anything
you'd like a second opinion on -->
## What should reviewers focus on?
* 


## Checklist
- [ ] My PR name is descriptive and in imperative tense
- [ ] My commit messages are descriptive and in imperative tense. My
commits are atomic and trivial commits are squashed or fixup'd into
non-trivial commits
- [ ] I have run the appropriate linter(s)
- [ ] I have requested a review from the PL, as well as other devs who
have background knowledge on this PR or who will be building on top of
this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants