Remove archived subjects from user management table and dropdown (#124)

Co-authored-by: Chinemerem <[email protected]>

Author: ColinToft

src/components/dashboard/user_management/EditableSubscriptionsCell.tsx

@@ -78,14 +78,9 @@ const EditableSubscriptionsCell: React.FC<EditableSubscriptionsCellProps> = ({
 
   // Get sorted subjects for dropdown display
   const sortedSubjects = useMemo(() => {
-    return [...allSubjects].sort((a, b) => {
-      // First sort by archived status (unarchived first)
-      if (a.archived !== b.archived) {
-        return a.archived ? 1 : -1;
-      }
-      // Then sort by ID
-      return a.id - b.id;
-    });
+    return [...allSubjects]
+      .filter((subject) => !subject.archived) // Filter out archived subjects
+      .sort((a, b) => a.id - b.id); // Now we only need to sort by ID since all subjects are unarchived
   }, [allSubjects]);
 
   // Define saveSubscriptions with useCallback so it can be used in dependency arrays
@@ -113,8 +108,14 @@ const EditableSubscriptionsCell: React.FC<EditableSubscriptionsCellProps> = ({
   // Initialize selected subjects from current mailing lists
   useEffect(() => {
     if (!isSaving) {
-      setSelectedSubjectIds(mailingLists.map((list) => list.subjectId));
-      setLocalMailingLists(mailingLists);
+      setSelectedSubjectIds(
+        mailingLists
+          .filter((list) => !list.subject.archived)
+          .map((list) => list.subjectId)
+      );
+      setLocalMailingLists(
+        mailingLists.filter((list) => !list.subject.archived)
+      );
     }
   }, [mailingLists, isSaving]);
 
@@ -125,12 +126,12 @@ const EditableSubscriptionsCell: React.FC<EditableSubscriptionsCellProps> = ({
       .map((id) => {
         // Try to find existing mailing list first
         const existingList = mailingLists.find((list) => list.subjectId === id);
-        if (existingList) return existingList;
+        if (existingList && !existingList.subject.archived) return existingList;
 
         // If not, create a new one based on the subject from our full subjects list
         const subject = subjectsById[id];
 
-        if (!subject) return null;
+        if (!subject || subject.archived) return null;
 
         return {
           subjectId: subject.id,
@@ -139,15 +140,10 @@ const EditableSubscriptionsCell: React.FC<EditableSubscriptionsCellProps> = ({
       })
       .filter(Boolean) as MailingList[];
 
-    // Sort the new mailing lists by archived status and ID
-    const sortedMailingLists = [...newMailingListsUnsorted].sort((a, b) => {
-      // First sort by archived status (unarchived first)
-      if (a.subject.archived !== b.subject.archived) {
-        return a.subject.archived ? 1 : -1;
-      }
-      // Then sort by ID
-      return a.subjectId - b.subjectId;
-    });
+    // Sort the new mailing lists by ID
+    const sortedMailingLists = [...newMailingListsUnsorted].sort(
+      (a, b) => a.subjectId - b.subjectId
+    );
 
     setLocalMailingLists(sortedMailingLists);
   }, [selectedSubjectIds, mailingLists, subjectsById]);