Skip to content

Fix long text making strange scroll behaviour, fix zIndex#133

Merged
ChinemeremChigbo merged 3 commits intomainfrom
colin/email-subs-are-too-long
Apr 19, 2025
Merged

Fix long text making strange scroll behaviour, fix zIndex#133
ChinemeremChigbo merged 3 commits intomainfrom
colin/email-subs-are-too-long

Conversation

@ColinToft
Copy link
Contributor

@ColinToft ColinToft commented Apr 19, 2025

Notion Ticket

Ticket Name

Summary & Review Focus

I am a huge fan of Popovers and zIndex! (jkjk they are pretty annoying)

  • Fixes scroll issue with long email tags

  • Fixes role cell z index issues where they go above sticky row but not the "User Management" row

  • The issue with the long subject names making weird scroll behaviour is because of Popovers, especially popovers longer than the scroll view they are in

  • Fixed by removing them from the Portal (I am no longer a fan of portals since they often cause the thing where the whole page scrolls)

  • Also fixed by making the max width of the popover 80vw, since even taking it out of the portal made that weird thing happen where the line at the bottom of the header randomly stops and there's just blank space to the right

  • Since the portal is gone, the popover was above the sticky header but not the "User Management" header -> fixed by giving higher zIndex to sticky header and even higher to the filter popup lol, a little sketch but at this point i wasn't sure what else to do

Testing Instructions

Checklist

  • PR title is descriptive and in imperative tense
  • Commit messages are descriptive, atomic, and follow best practices
  • Linter(s) have been run
  • Requested reviews from the PL and relevant team members

@vercel
Copy link

vercel bot commented Apr 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2025 1:52am

@ChinemeremChigbo ChinemeremChigbo merged commit 139d8cb into main Apr 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants