Add types for department/position

Author: carolynzhang18

backend/typescript/models/admin.model.ts

@@ -6,13 +6,14 @@ import {
   Table,
 } from "sequelize-typescript";
 import User from "./user.model";
+import { Department } from "../types";
 
 @Table({ tableName: "admins" })
 export default class Admin extends Model {
   @ForeignKey(() => User)
   @Column({ type: DataType.STRING, primaryKey: true })
   userId!: string;
 
-  @Column({ type: DataType.ARRAY(DataType.STRING) })
-  authorizedDepartments!: string[];
+  @Column({ type: DataType.ARRAY(DataType.ENUM(...Object.values(Department))) })
+  authorizedDepartments!: Department[];
 }

backend/typescript/models/position.model.ts

@@ -1,11 +1,11 @@
 import { Column, DataType, Model, Table } from "sequelize-typescript";
-import { Department } from "../types";
+import { Department, PositionTitle, PositionTitles } from "../types";
 
 @Table({ tableName: "positions" })
 export default class Position extends Model {
-  @Column({ type: DataType.STRING, primaryKey: true })
-  title!: string;
+  @Column({ type: DataType.ENUM(...PositionTitles), primaryKey: true })
+  title!: PositionTitle;
 
   @Column({ type: DataType.ENUM(...Object.values(Department)) })
-  department!: string;
+  department!: Department;
 }

backend/typescript/models/user.model.ts

@@ -8,7 +8,7 @@ import {
   Model,
   Table,
 } from "sequelize-typescript";
-import { Role } from "../types";
+import { PositionTitle, Role } from "../types";
 import ApplicationDashboardTable from "./applicationDashboard.model";
 import Position from "./position.model";
 
@@ -34,7 +34,7 @@ export default class User extends Model {
 
   @ForeignKey(() => Position)
   @Column({ type: DataType.STRING })
-  position!: string;
+  position!: PositionTitle;
 
   @HasMany(() => ApplicationDashboardTable)
   applicationDashboards?: ApplicationDashboardTable[];

backend/typescript/types.ts

@@ -127,13 +127,44 @@ export enum ApplicantRole {
 }
 
 export enum Department {
-  ENGINEERING = "Engineering",
-  DESIGN = "Design",
-  PRODUCT = "Product",
-  COMMUNITY = "Community",
+  Engineering = "Engineering",
+  Design = "Design",
+  Product = "Product",
+  Community = "Community",
 }
 
-export type Position = {
-  title: string;
-  department: Department;
-};
+export const EngineeringPositionTitles = [
+  "Project Lead",
+  "Developer",
+  "VP Engineering",
+] as const;
+export const DesignPositionTitles = [
+  "Designer",
+  "VP Design",
+  "Graphic Designer",
+] as const;
+export const ProductPositionTitles = ["Product Manager", "VP Product"] as const;
+export const CommunityPositionTitles = [
+  "President",
+  "VP Scoping",
+  "VP Talent",
+  "VP Finance",
+  "Director Lead",
+  "Internal Director",
+  "External Director",
+  "Content Strategist",
+] as const;
+
+export const PositionTitles = [
+  ...EngineeringPositionTitles,
+  ...DesignPositionTitles,
+  ...ProductPositionTitles,
+  ...CommunityPositionTitles,
+] as const;
+
+// Union types
+export type EngineeringPositionTitle = typeof EngineeringPositionTitles[number];
+export type DesignPositionTitle = typeof DesignPositionTitles[number];
+export type ProductPositionTitle = typeof ProductPositionTitles[number];
+export type CommunityPositionTitle = typeof CommunityPositionTitles[number];
+export type PositionTitle = typeof PositionTitles[number];