added types and update query

Author: gavxue

.claude/settings.local.json

@@ -0,0 +1,13 @@
+{
+  "permissions": {
+    "allow": [
+      "Bash(git log:*)",
+      "Bash(npx tsc --noEmit)",
+      "Bash(./node_modules/.bin/tsc:*)",
+      "Bash(npm run lint)",
+      "Bash(npm run fix:*)"
+    ],
+    "deny": [],
+    "ask": []
+  }
+}

backend/typescript/graphql/index.ts

@@ -87,6 +87,7 @@ const graphQLMiddlewares = {
     bulkCreateReviewedApplicantRecord: authorizedByAllRoles(),
     deleteReviewedApplicantRecord: authorizedByAllRoles(),
     bulkDeleteReviewedApplicantRecord: authorizedByAllRoles(),
+    updateReviewedApplicantRecord: authorizedByAllRoles(),
     createUser: authorizedByAdmin(),
     updateUser: authorizedByAdmin(),
     deleteUserById: authorizedByAdmin(),

backend/typescript/graphql/resolvers/reviewedApplicantRecordResolver.ts

@@ -3,6 +3,7 @@ import {
   ReviewedApplicantRecordDTO,
   CreateReviewedApplicantRecordDTO,
   DeleteReviewedApplicantRecordDTO,
+  UpdateReviewedApplicantRecordDTO,
 } from "../../types";
 import { getErrorMessage } from "../../utilities/errorUtils";
 
@@ -61,6 +62,19 @@ const reviewedApplicantRecordResolvers = {
         throw new Error(getErrorMessage(error));
       }
     },
+
+    updateReviewedApplicantRecord: async (
+      _parent: undefined,
+      args: { input: UpdateReviewedApplicantRecordDTO },
+    ): Promise<ReviewedApplicantRecordDTO> => {
+      try {
+        return await reviewedApplicantRecordService.updateReviewedApplicantRecord(
+          args.input,
+        );
+      } catch (error) {
+        throw new Error(getErrorMessage(error));
+      }
+    },
   },
 };
 

backend/typescript/graphql/types/reviewedApplicantRecordTypes.ts

@@ -44,6 +44,13 @@ const reviewedApplicantRecordTypes = gql`
     reviewerId: Int!
   }
 
+  input UpdateReviewedApplicantRecordInput {
+    applicantRecordId: ID!
+    reviewerId: Int!
+    review: ReviewInput
+    status: String
+  }
+
   extend type Mutation {
     createReviewedApplicantRecord(
       input: CreateReviewedApplicantRecordInput!
@@ -60,6 +67,10 @@ const reviewedApplicantRecordTypes = gql`
     bulkDeleteReviewedApplicantRecord(
       inputs: [DeleteReviewedApplicantRecord!]!
     ): [ReviewedApplicantRecord!]!
+
+    updateReviewedApplicantRecord(
+      input: UpdateReviewedApplicantRecordInput!
+    ): ReviewedApplicantRecord!
   }
 `;
 

backend/typescript/services/implementations/reviewedApplicantRecordService.ts

@@ -1,9 +1,11 @@
 import { sequelize } from "../../models";
 import ReviewedApplicantRecord from "../../models/reviewedApplicantRecord.model";
+import ApplicantRecord from "../../models/applicantRecord.model";
 import {
   ReviewedApplicantRecordDTO,
   CreateReviewedApplicantRecordDTO,
   DeleteReviewedApplicantRecordDTO,
+  UpdateReviewedApplicantRecordDTO,
 } from "../../types";
 
 import IReviewApplicantRecordService from "../interfaces/IReviewedApplicantRecordService";
@@ -80,6 +82,85 @@ class ReviewedApplicantRecordService implements IReviewApplicantRecordService {
 
     return deletedRecords.map((r) => r.toJSON() as ReviewedApplicantRecordDTO);
   }
+
+  /* eslint-disable class-methods-use-this */
+  async updateReviewedApplicantRecord({
+    applicantRecordId,
+    reviewerId,
+    review,
+    status,
+  }: UpdateReviewedApplicantRecordDTO): Promise<ReviewedApplicantRecordDTO> {
+    const updatedRecord = await sequelize.transaction(async (t) => {
+      const reviewedRecord = await ReviewedApplicantRecord.findOne({
+        where: { applicantRecordId, reviewerId },
+        transaction: t,
+      });
+
+      if (!reviewedRecord) {
+        throw new Error(
+          `ReviewedApplicantRecord not found for applicantRecordId: ${applicantRecordId} and reviewerId: ${reviewerId}`,
+        );
+      }
+
+      const oldReviewedScore = reviewedRecord.score || 0;
+
+      if (review !== undefined) {
+        reviewedRecord.review = {
+          ...reviewedRecord.review,
+          ...review,
+        };
+
+        const { passionFSG, teamPlayer, desireToLearn, skill } =
+          reviewedRecord.review;
+
+        if (
+          passionFSG === undefined ||
+          teamPlayer === undefined ||
+          desireToLearn === undefined ||
+          skill === undefined
+        ) {
+          throw new Error(
+            "Invalid review update: All four score fields (passionFSG, teamPlayer, desireToLearn, skill) must be present after the update",
+          );
+        }
+
+        reviewedRecord.score = passionFSG + teamPlayer + desireToLearn + skill;
+
+        if (review.skillCategory !== undefined) {
+          reviewedRecord.skillCategory = review.skillCategory;
+        }
+      }
+
+      if (status !== undefined) {
+        reviewedRecord.status = status;
+      }
+
+      await reviewedRecord.save({ transaction: t });
+
+      const newReviewedScore = reviewedRecord.score || 0;
+
+      const applicantRecord = await ApplicantRecord.findOne({
+        where: { id: applicantRecordId },
+        transaction: t,
+      });
+
+      if (!applicantRecord) {
+        throw new Error(
+          `ApplicantRecord not found for applicantRecordId: ${applicantRecordId}`,
+        );
+      }
+
+      const oldCombinedScore = applicantRecord.combined_score || 0;
+      applicantRecord.combined_score =
+        oldCombinedScore - oldReviewedScore + newReviewedScore;
+
+      await applicantRecord.save({ transaction: t });
+
+      return reviewedRecord;
+    });
+
+    return updatedRecord.toJSON() as ReviewedApplicantRecordDTO;
+  }
 }
 
 export default ReviewedApplicantRecordService;

backend/typescript/services/interfaces/IReviewedApplicantRecordService.ts

@@ -2,6 +2,7 @@ import {
   ReviewedApplicantRecordDTO,
   CreateReviewedApplicantRecordDTO,
   DeleteReviewedApplicantRecordDTO,
+  UpdateReviewedApplicantRecordDTO,
 } from "../../types";
 
 interface IReviewApplicantRecordService {
@@ -37,6 +38,15 @@ interface IReviewApplicantRecordService {
   bulkDeleteReviewedApplicantRecord(
     deleteReviewedApplicantRecords: DeleteReviewedApplicantRecordDTO[],
   ): Promise<ReviewedApplicantRecordDTO[]>;
+
+  /**
+   * Updates the review content and/or status of a ReviewedApplicantRecord
+   * Also updates the combined score in the ApplicantRecord table
+   * @Param updateReviewedApplicantRecordDTO data to update reviewed applicant record
+   */
+  updateReviewedApplicantRecord(
+    updateReviewedApplicantRecordDTO: UpdateReviewedApplicantRecordDTO,
+  ): Promise<ReviewedApplicantRecordDTO>;
 }
 
 export default IReviewApplicantRecordService;

backend/typescript/types.ts

@@ -220,6 +220,13 @@ export type DeleteReviewedApplicantRecordDTO = {
   reviewerId: number;
 };
 
+export type UpdateReviewedApplicantRecordDTO = {
+  applicantRecordId: string;
+  reviewerId: number;
+  review?: Review;
+  status?: ReviewStatus;
+};
+
 export type AdminCommentDTO = {
   id: string;
   userId: number;