Skip to content

Commit 140611f

Browse files
author
Maggie Chen
committed
update types to reflect enum drop
1 parent b183dda commit 140611f

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

backend/typescript/graphql/types/reviewDashboardType.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { gql } from "apollo-server-express";
2-
import { ApplicationStatus, PositionTitle, ReviewerDTO } from "../../types";
32

43
const reviewDashboardType = gql`
54
type ReviewerDTO {

backend/typescript/services/implementations/reviewDashboardService.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { PositionTitle, ReviewDashboardRowDTO } from "../../types";
1+
import { ReviewDashboardRowDTO } from "../../types";
22
import IReviewDashboardService from "../interfaces/IReviewDashboardService";
33
import { getErrorMessage } from "../../utilities/errorUtils";
44
import logger from "../../utilities/logger";
@@ -10,7 +10,7 @@ function toDTO(model: ApplicantRecord): ReviewDashboardRowDTO {
1010
return {
1111
firstName: model.applicant!.firstName,
1212
lastName: model.applicant!.lastName,
13-
position: model.position as PositionTitle,
13+
position: model.position,
1414
timesApplied: model.applicant!.timesApplied.toString(),
1515
applicationStatus: model.status,
1616
choice: model.choice,

backend/typescript/types.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export type UserDTO = {
2929
firstName: string;
3030
lastName: string;
3131
email: string;
32-
position?: PositionTitle;
32+
position?: string;
3333
role: Role;
3434
};
3535

@@ -80,7 +80,7 @@ export type ApplicantDTO = {
8080
export type ApplicantRecordDTO = {
8181
id: number;
8282
applicantId: string;
83-
position: PositionTitle; // EDIT LATER
83+
position: string;
8484
roleSpecificQuestions: string[];
8585
choice: number;
8686
status: ApplicationStatus;
@@ -111,7 +111,7 @@ export type ReviewerDTO = {
111111
export type ReviewDashboardRowDTO = {
112112
firstName: string;
113113
lastName: string;
114-
position: PositionTitle;
114+
position: string;
115115
timesApplied: string;
116116
applicationStatus: ApplicationStatus;
117117
choice: number;

0 commit comments

Comments
 (0)