Skip to content

Commit 228bf67

Browse files
committed
minor fixes to types and allowing null values
1 parent 6a1062f commit 228bf67

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

backend/typescript/graphql/types/reviewDashboardType.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ const reviewDashboardType = gql`
2424
desireToLearn: Int
2525
skill: Int
2626
skillCategory: String
27+
comments: String
2728
}
2829
2930
type ReviewDetails {
@@ -39,7 +40,7 @@ const reviewDashboardType = gql`
3940
program: String!
4041
resumeUrl: String!
4142
applicationStatus: String!
42-
skillCategory: String!
43+
skillCategory: String
4344
reviewDetails: [ReviewDetails!]!
4445
}
4546

backend/typescript/services/implementations/reviewDashboardService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ function toSidePanelDTO(model: ApplicantRecord): ReviewDashboardSidePanelDTO {
4141
program: model.applicant!.program,
4242
resumeUrl: model.applicant!.resumeUrl,
4343
applicationStatus: model.status,
44-
skillCategory: model.skillCategory || "Junior", // seems skill category can be null in the applicant record db right now
44+
skillCategory: model.skillCategory,
4545
reviewDetails: reviewDetails,
4646
};
4747
}

backend/typescript/types.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,7 @@ export type Review = {
198198
desireToLearn?: number;
199199
skill?: number;
200200
skillCategory?: SkillCategory;
201+
comments?: string;
201202
};
202203

203204
export type ReviewedApplicantRecordDTO = {
@@ -222,7 +223,7 @@ export type ReviewDashboardSidePanelDTO = {
222223
program: string;
223224
resumeUrl: string;
224225
applicationStatus: ApplicationStatus;
225-
skillCategory: SkillCategory;
226+
skillCategory: SkillCategory | null;
226227
reviewDetails: ReviewDetails[];
227228
};
228229

0 commit comments

Comments
 (0)