use Review type in graphQL schema

Author: isabellehuangg

backend/typescript/graphql/index.ts

@@ -1,7 +1,6 @@
 import { makeExecutableSchema, gql } from "apollo-server-express";
 import { applyMiddleware } from "graphql-middleware";
 import { merge } from "lodash";
-import { GraphQLScalarType, Kind } from "graphql";
 
 import {
   isAuthorizedByEmail,
@@ -37,54 +36,20 @@ const mutation = gql`
   }
 `;
 
-const scalarTypes = gql`
-  scalar JSON
-`;
-
-const JSONScalar = new GraphQLScalarType({
-  name: "JSON",
-  description: "JSON scalar type",
-  serialize: (value) => value,
-  parseValue: (value) => value,
-  parseLiteral: (ast) => {
-    switch (ast.kind) {
-      case Kind.STRING:
-      case Kind.BOOLEAN:
-        return ast.value;
-      case Kind.INT:
-      case Kind.FLOAT:
-        return parseFloat(ast.value);
-      case Kind.OBJECT:
-        return ast.fields.reduce((obj: any, field: any) => {
-          obj[field.name.value] = JSONScalar.parseLiteral(field.value, {});
-          return obj;
-        }, {});
-      case Kind.LIST:
-        return ast.values.map((value: any) => JSONScalar.parseLiteral(value, {}));
-      default:
-        return null;
-    }
-  },
-});
-
 const executableSchema = makeExecutableSchema({
   typeDefs: [
     query,
     mutation,
-    scalarTypes,
     authType,
     entityType,
     simpleEntityType,
     userType,
     reviewDashboardType,
-    reviewedApplicantRecordTypes
+    reviewedApplicantRecordTypes,
     adminCommentType,
     reviewPageType,
   ],
   resolvers: merge(
-    {
-      JSON: JSONScalar,
-    },
     authResolvers,
     entityResolvers,
     simpleEntityResolvers,
@@ -118,10 +83,6 @@ const graphQLMiddlewares = {
     createSimpleEntity: authorizedByAllRoles(),
     updateSimpleEntity: authorizedByAllRoles(),
     deleteSimpleEntity: authorizedByAllRoles(),
-    changeRating: authorizedByAllRoles(),
-    changeSkillCategory: authorizedByAllRoles(),
-    updateApplications: authorizedByAllRoles(),
-    modifyFinalComments: authorizedByAllRoles(),
     createReviewedApplicantRecord: authorizedByAllRoles(),
     bulkCreateReviewedApplicantRecord: authorizedByAllRoles(),
     deleteReviewedApplicantRecord: authorizedByAllRoles(),

backend/typescript/graphql/types/reviewedApplicantRecordTypes.ts

@@ -1,10 +1,32 @@
 import { gql } from "apollo-server-express";
 
 const reviewedApplicantRecordTypes = gql`
+  enum SkillCategory {
+    JUNIOR
+    INTERMEDIATE
+    SENIOR
+  }
+
+  type Review {
+    passionFSG: Int
+    teamPlayer: Int
+    desireToLearn: Int
+    skill: Int
+    skillCategory: SkillCategory
+  }
+
+  input ReviewInput {
+    passionFSG: Int
+    teamPlayer: Int
+    desireToLearn: Int
+    skill: Int
+    skillCategory: SkillCategory
+  }
+
   type ReviewedApplicantRecord {
     applicantRecordId: ID!
     reviewerId: Int!
-    review: JSON
+    review: Review
     status: String
     score: Int
     reviewerHasConflict: Boolean
@@ -13,7 +35,7 @@ const reviewedApplicantRecordTypes = gql`
   input CreateReviewedApplicantRecordInput {
     applicantRecordId: ID!
     reviewerId: Int!
-    review: JSON
+    review: ReviewInput
     status: String
   }