Skip to content

Commit 3e1d29d

Browse files
author
ruiichen
committed
unfuck rebase
1 parent 44a749c commit 3e1d29d

File tree

4 files changed

+24
-125
lines changed

4 files changed

+24
-125
lines changed

backend/typescript/graphql/index.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ import reviewDashboardResolvers from "./resolvers/reviewDashboardResolvers";
1919
import reviewDashboardType from "./types/reviewDashboardType";
2020
import adminCommentResolvers from "./resolvers/adminCommentsResolvers";
2121
import adminCommentType from "./types/adminCommentsType";
22-
import dashboardType from "./types/dashboardType";
23-
import dashboardResolvers from "./resolvers/dashboardResolvers";
24-
import reviewType from "./types/reviewType";
2522
import reviewPageType from "./types/reviewPageType";
2623
import reviewPageResolvers from "./resolvers/reviewPageResolvers";
2724

@@ -47,7 +44,6 @@ const executableSchema = makeExecutableSchema({
4744
userType,
4845
reviewDashboardType,
4946
adminCommentType,
50-
dashboardType,
5147
reviewPageType,
5248
],
5349
resolvers: merge(
@@ -57,7 +53,6 @@ const executableSchema = makeExecutableSchema({
5753
userResolvers,
5854
reviewDashboardResolvers,
5955
adminCommentResolvers,
60-
dashboardResolvers,
6156
reviewPageResolvers,
6257
),
6358
});

backend/typescript/graphql/types/dashboardType.ts

Lines changed: 0 additions & 100 deletions
This file was deleted.

backend/typescript/graphql/types/reviewPageType.ts

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,30 @@
11
import { gql } from "apollo-server-express";
22

33
const reviewPageType = gql`
4+
type ApplicationDTO {
5+
id: Int!
6+
academicOrCoop: String!
7+
academicYear: String!
8+
email: String!
9+
firstChoiceRole: String!
10+
firstName: String!
11+
heardFrom: String!
12+
lastName: String!
13+
locationPreference: String!
14+
program: String!
15+
pronouns: String!
16+
pronounsSpecified: String!
17+
resumeUrl: String!
18+
roleSpecificQuestions: [String!]!
19+
secondChoiceRole: String!
20+
shortAnswerQuestions: [String!]!
21+
status: String!
22+
secondChoiceStatus: String!
23+
term: String!
24+
timesApplied: String!
25+
timestamp: Int
26+
}
27+
428
extend type Query {
529
reviewApplicantPage(reviewedApplicantRecordId: String!): ApplicationDTO!
630
}

backend/typescript/types.ts

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -33,26 +33,6 @@ export type UserDTO = {
3333
role: Role;
3434
};
3535

36-
// DEPRECATED - TO BE REMOVED AT THE END OF S25
37-
export type ApplicationDashboardDTO = {
38-
id: number;
39-
reviewerEmail: string;
40-
passionFSG: number;
41-
teamPlayer: number;
42-
desireToLearn: number;
43-
skill: number;
44-
skillCategory: string;
45-
reviewerComments: string;
46-
recommendedSecondChoice: string;
47-
reviewerId: number;
48-
applicationId: number;
49-
};
50-
51-
export type ApplicationDashboardInput = Omit<
52-
ApplicationDashboardDTO,
53-
"applicationId"
54-
>;
55-
5636
export type ApplicationDTO = {
5737
id: number;
5838
academicOrCoop: string;

0 commit comments

Comments
 (0)