finished first section

Author: ruiichen

backend/typescript/graphql/resolvers/reviewDashboardResolvers.ts

@@ -21,9 +21,12 @@ const reviewDashboardResolvers = {
     },
   },
   Mutation: {
-    delegateReviewers: async (): Promise<ReviewedApplicantRecordDTO[]> => {
+    delegateReviewers: async (
+      _parent: undefined,
+      args: { positions: string[] },
+    ): Promise<ReviewedApplicantRecordDTO[]> => {
       try {
-        return await reviewDashboardService.delegateReviewers();
+        return await reviewDashboardService.delegateReviewers(args.positions);
       } catch (error) {
         throw new Error(getErrorMessage(error));
       }

backend/typescript/graphql/types/reviewDashboardType.ts

@@ -24,7 +24,7 @@ const reviewDashboardType = gql`
     reviewers: [ReviewerDTO!]!
     totalScore: Int
   }
-  
+
   type ReviewedApplicantRecordDTO {
     applicantRecordId: String!
     reviewerId: Int!
@@ -42,7 +42,7 @@ const reviewDashboardType = gql`
   }
 
   extend type Mutation {
-    delegateReviewers: [ReviewedApplicantRecordDTO!]!
+    delegateReviewers(positions: [String!]!): [ReviewedApplicantRecordDTO!]!
   }
 `;
 

backend/typescript/services/implementations/reviewDashboardService.ts

@@ -7,15 +7,19 @@ import {
   DesignPositionTitles,
   ProductPositionTitles,
   CommunityPositionTitles,
+  CreateReviewedApplicantRecordDTO,
 } from "../../types";
 import IReviewDashboardService from "../interfaces/IReviewDashboardService";
 import { getErrorMessage } from "../../utilities/errorUtils";
 import logger from "../../utilities/logger";
 import ApplicantRecord from "../../models/applicantRecord.model";
 import User from "../../models/user.model";
+import ReviewedApplicantRecordService from "./reviewedApplicantRecordService";
 
 const Logger = logger(__filename);
 
+const reviewedApplicantRecordService = new ReviewedApplicantRecordService();
+
 function toDTO(model: ApplicantRecord): ReviewDashboardRowDTO {
   return {
     firstName: model.applicant!.firstName,
@@ -83,11 +87,13 @@ class ReviewDashboardService implements IReviewDashboardService {
     }
   }
 
-  async delegateReviewers(): Promise<ReviewedApplicantRecordDTO[]> {
+  async delegateReviewers(
+    positions: string[],
+  ): Promise<ReviewedApplicantRecordDTO[]> {
     // NOTE: We do not have to concern ourselves with locality. That is, each user can be
     //       assigned to the same partner every time.
 
-    const delegations = new Map<string, [string, string | undefined]>();
+    const delegations = Array<CreateReviewedApplicantRecordDTO>();
     // maps (applicant_record_id) => pair of user_ids assigned to it
 
     // STEP 1:
@@ -105,14 +111,14 @@ class ReviewDashboardService implements IReviewDashboardService {
       // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       const pos = user.position!;
       const arr = map.get(pos) ?? [];
-      arr.push(user.id.toString());
+      arr.push(user.id);
       map.set(pos, arr);
       return map;
-    }, new Map<string, string[]>());
+    }, new Map<string, number[]>());
 
     // Build FSM
     // maps (position title) => (current index of list, list of users with position_title)
-    const FSM = new Map<string, [number, (string | undefined)[]]>(
+    const FSM = new Map<string, [number, (number | undefined)[]]>(
       [
         ...EngineeringPositionTitles,
         ...DesignPositionTitles,
@@ -166,23 +172,29 @@ class ReviewDashboardService implements IReviewDashboardService {
       newCount++;
       newCount %= FSM.get(record.position)![1].length;
       FSM.set(record.position, [newCount, userIds]);
-      delegations.set(record.id, [assignedReviewer1!, assignedReviewer2]);
-      /* eslint-enable @typescript-eslint/no-non-null-assertion */
-      if (record.position === "Developer") {
-        console.log(
-          `Assigned reviewers for applicant ${record.id} (${record.position}):`,
-          assignedReviewer1,
-          "and",
-          assignedReviewer2,
-        );
+
+      if (assignedReviewer1 !== undefined) {
+        delegations.push({
+          applicantRecordId: record.id,
+          reviewerId: assignedReviewer1,
+        });
+      }
+
+      if (assignedReviewer2 !== undefined) {
+        delegations.push({
+          applicantRecordId: record.id,
+          reviewerId: assignedReviewer2,
+        });
       }
     });
 
     // STEP 3:
     //   Batch the delegations into ReviewedApplicantRecords
     //   NOTE: do not add the sentinel value we inserted earlier.
-
-    return [];
+    console.log(delegations);
+    return reviewedApplicantRecordService.bulkCreateReviewedApplicantRecord(
+      delegations,
+    );
   }
 }
 

backend/typescript/services/interfaces/IReviewDashboardService.ts

@@ -14,8 +14,9 @@ interface IReviewDashboardService {
   /**
    * Assigns each user to an applicant record to review, and
    * returns the newly created ReviewedApplicantRecords
+   * @Param positions the list of positions the algorithm should run on
    */
-  delegateReviewers(): Promise<ReviewedApplicantRecordDTO[]>;
+  delegateReviewers(positions: string[]): Promise<ReviewedApplicantRecordDTO[]>;
 }
 
 export default IReviewDashboardService;