.

Author: mxc-maggiechen

backend/typescript/graphql/index.ts

@@ -20,8 +20,6 @@ import dashboardResolvers from "./resolvers/dashboardResolvers";
 import reviewType from "./types/reviewType";
 import reviewedApplicantRecordType from "./types/reviewedApplicantRecordType";
 import reviewedApplicantRecordResolvers from "./resolvers/reviewedApplicantRecordResolver";
-import applicantRecordResolvers from "./resolvers/applicantRecordResolver";
-import applicantRecordType from "./types/applicantRecordType";
 
 const query = gql`
   type Query {
@@ -46,7 +44,6 @@ const executableSchema = makeExecutableSchema({
     userType,
     dashboardType,
     reviewedApplicantRecordType,
-    applicantRecordType,
   ],
   resolvers: merge(
     authResolvers,
@@ -55,7 +52,6 @@ const executableSchema = makeExecutableSchema({
     userResolvers,
     dashboardResolvers,
     reviewedApplicantRecordResolvers,
-    applicantRecordResolvers,
   ),
 });
 
@@ -98,6 +94,11 @@ const graphQLMiddlewares = {
     logout: isAuthorizedByUserId("userId"),
     resetPassword: isAuthorizedByEmail("email"),
     sendSignInLink: authorizedByAllRoles(),
+
+    // this should be guarded by isAuthorizedReviewerForApplication
+    bulkCreateReviewedApplicantRecords: authorizedByAllRoles(),
+    updateReviewedApplicantRecordReview: authorizedByAllRoles(),
+    updateReviewedApplicantRecordStatus: authorizedByAllRoles(),
   },
 };
 

backend/typescript/graphql/resolvers/applicantRecordResolver.ts

@@ -27,7 +27,7 @@ const reviewedApplicantRecordType = gql`
     applicantRecordId: ID!
     reviewerId: ID!
     review: Review
-    status: ReviewStatusEnum!
+    status: String!
   }
 
   input ReviewedApplicantRecordPK {

backend/typescript/graphql/types/applicantRecordType.ts

@@ -5,6 +5,7 @@ import {
   ReviewedApplicantRecordPK,
   ReviewStatus,
   ReviewStatusEnum,
+  SkillCategoryEnum,
 } from "../../types";
 import { IReviewedApplicantRecordService } from "../interfaces/reviewedApplicantRecordService";
 import { sequelize } from "../../models";
@@ -60,6 +61,15 @@ class ReviewedApplicantRecordService
   ): Promise<ReviewedApplicantRecordDTO> => {
     const { reviewerId, applicantRecordId } = reviewedApplicantRecordPK;
     try {
+      if (
+        review.skillCategory &&
+        !Object.values(SkillCategoryEnum).includes(
+          review.skillCategory as SkillCategoryEnum,
+        )
+      ) {
+        throw new Error("Review has invalid skill category");
+      }
+
       const updatedReviewedApplicantRecord = await sequelize.transaction(
         async (transaction) => {
           const reviewedApplicantRecord = await ReviewedApplicantRecord.findOne(
@@ -105,6 +115,11 @@ class ReviewedApplicantRecordService
     const { reviewerId, applicantRecordId } = reviewedApplicantRecordPK;
 
     try {
+      if (
+        !Object.values(ReviewStatusEnum).includes(status as ReviewStatusEnum)
+      ) {
+        throw new Error("Invalid review status");
+      }
       const updatedReviewedApplicantRecord = await sequelize.transaction(
         async (transaction) => {
           const reviewedApplicantRecord = await ReviewedApplicantRecord.findOne(