Skip to content

Commit ffd3b28

Browse files
committed
allow partial updates for scores
1 parent 8feeab2 commit ffd3b28

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

backend/typescript/services/implementations/reviewedApplicantRecordService.ts

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -181,18 +181,12 @@ class ReviewedApplicantRecordService implements IReviewApplicantRecordService {
181181
const { passionFSG, teamPlayer, desireToLearn, skill } =
182182
reviewedRecord.review;
183183

184-
if (
185-
passionFSG === undefined ||
186-
teamPlayer === undefined ||
187-
desireToLearn === undefined ||
188-
skill === undefined
189-
) {
190-
throw new Error(
191-
"Invalid review update: All four score fields (passionFSG, teamPlayer, desireToLearn, skill) must be present after the update",
192-
);
193-
}
194-
195-
reviewedRecord.score = passionFSG + teamPlayer + desireToLearn + skill;
184+
let calculatedScore = 0;
185+
if (passionFSG !== undefined) calculatedScore += passionFSG;
186+
if (teamPlayer !== undefined) calculatedScore += teamPlayer;
187+
if (desireToLearn !== undefined) calculatedScore += desireToLearn;
188+
if (skill !== undefined) calculatedScore += skill;
189+
reviewedRecord.score = calculatedScore;
196190

197191
if (review.skillCategory !== undefined) {
198192
reviewedRecord.skillCategory = review.skillCategory;

0 commit comments

Comments
 (0)