Tidy comments and test scaffolding

Author: alan-forbes-cp

.github/actions/setup_build/action.yml

@@ -103,6 +103,7 @@ runs:
       if: inputs.os == 'windows' && inputs.llvm_source == 'install'
       shell: pwsh
       env:
+        # Map inputs.llvm_version to specific download release here.
         LLVM_RELEASE: "${{ inputs.llvm_version == '20' && '20.1.2' || '19.1.7' }}"
       run: |
         Invoke-WebRequest https://github.com/llvm/llvm-project/releases/download/llvmorg-$env:LLVM_RELEASE/clang+llvm-$env:LLVM_RELEASE-x86_64-pc-windows-msvc.tar.xz -OutFile clang+llvm-$env:LLVM_RELEASE-x86_64-pc-windows-msvc.tar.xz

.github/workflows/run_ock_internal_tests.yml

@@ -198,8 +198,6 @@ jobs:
   # Based on: mr-windows-msvc-x86_64-llvm-previous-cl3.0-offline
   run_windows_msvc_x86_64_llvm_latest_cl3_0_offline:
     runs-on: windows-2019
-    # do not run as PR job due to not yet supporting windows install
-    #if: contains(inputs.target_list, 'host_x86_64_windows') && !inputs.is_pull_request
     if: contains(inputs.target_list, 'host_x86_64_windows')
     steps:
       - name: Setup Windows llvm base
@@ -216,7 +214,6 @@ jobs:
         with:
           llvm_version: ${{ inputs.llvm_current }}
           os: windows
-          #llvm_source: ${{ inputs.llvm_source == 'install' && 'cache' || inputs.llvm_source }}
           llvm_source: ${{ inputs.llvm_source }}
           github_token: ${{ secrets.GITHUB_TOKEN }}
 

.github/workflows/run_pr_tests_caller.yml

@@ -28,6 +28,3 @@ jobs:
       llvm_source: install
       llvm_previous: 19
       llvm_current: 20
-      target_list: '[ "host_x86_64_windows" ]'
-
-