SonarCloud remove candidate rule: java:S1450 Private fields only used as local variables in methods should become local variables

[CDellaGiusta]

This poll closes Friday, April 18th 2025.

Candidate rule for removal: java:S1450
Number of issues with this rule in Uyuni: 43
Rule: Private fields only used as local variables in methods should become local variables
Software qualities impacted: MAINTAINABILITY
Why is this an issue:

When the value of a private field is always assigned to in a class' methods before being read, then it is not being used to store class information. Therefore, it should become a local variable in the relevant methods to prevent any misunderstanding.

Should it be removed?:
You may be using a set-only member to use in json serialization class

All rule issues in Uyuni: https://sonarcloud.io/project/issues?languages=java&issueStatuses=OPEN%2CCONFIRMED&id=uyuni-project_uyuni&rules=java%3AS1450

Examples in our code:

/**
* JSON response wrapper for an environment of a content project.
*/
public class EnvironmentResponse {
  private long id;
  private String projectLabel;
  private String label;
  .....

/**
* The Image info JSON object
*/
public class ImageInfoJson {
  private Long id;
  private String name;
  private String version;
  private String type;
  ......

[rjmateus]

There are some cases that we should look at and change the code according to this rule, but majority of them are basically what you say: classes to serialize to json. In this case I'm not sure if we should also add the getter and make it a pojo.