SonarCloud remove candidate rule: java:S2925 Thread.sleep should not be used in tests

[CDellaGiusta]

This poll closes Friday, April 18th 2025.

Candidate rule for removal: java:S2925
Number of issues with this rule in Uyuni: 36
Rule: Thread.sleep should not be used in tests
Software qualities impacted: MAINTAINABILITY
Why is this an issue:

In asynchronous testing, the test code is written in a way that allows it to wait for the asynchronous operation to complete before continuing with the test.

Using Thread.sleep in this case can cause flaky tests, slow test execution, and inaccurate test results.
It creates brittle tests that can fail unpredictably depending on the environment or load.

Use mocks or libraries such as Awaitility instead.
These tools provide features such as timeouts, assertions, and error handling to make it easier to write and manage asynchronous tests.

Should it be removed?:
Most of the issues on our code have a side comment, that justifies the waiting time for some reason.

All rule issues in Uyuni: https://sonarcloud.io/project/issues?languages=java&issueStatuses=OPEN%2CCONFIRMED&id=uyuni-project_uyuni&rules=java%3AS2925

Examples in our code:

finally {
          // Turn tracebacks and logging back on
          // wait for message to be sent
          int tries = 0;
          Thread.sleep(1000);


      public void run() {
          // simulate doing some work
          try {
              Thread.sleep(1);

      /*
       * We have to sleep here for a second since enabling/disabling a user within
       * the same second causes db problems.
       */
      Thread.sleep(1000);