SonarCloud remove candidate rule: java:S1602 Lambdas containing only one statement should not nest this statement in a block

[CDellaGiusta]

This poll closes Friday, April 18th 2025.

Candidate rule for removal: java:S1602
Number of issues with this rule in Uyuni: 22
Rule: Lambdas containing only one statement should not nest this statement in a block
Software qualities impacted: MAINTAINABILITY
Why is this an issue:

The right-hand side of a lambda expression can be written in two ways:

1. Expression notation: the right-hand side is as an expression, such as in (a, b) -> a + b
2. Block notation: the right-hand side is a conventional function body with a code block and an optional return statement,
   such as in (a, b) -> {return a + b;}

By convention, expression notation is preferred over block notation.
Block notation must be used when the function implementation requires more than one statement.
However, when the code block consists of only one statement (which may or may not be a return statement), it can be rewritten using expression notation.

This convention exists because expression notation has a cleaner, more concise,functional programming style and is regarded as more readable.

Should it be removed?:
Adding a block parentheses could increase readability of a complex lambda block

All rule issues in Uyuni: https://sonarcloud.io/project/issues?languages=java&issueStatuses=OPEN%2CCONFIRMED&id=uyuni-project_uyuni&rules=java%3AS1602

Examples in our code:

getSession().createQuery(query).getResultList().stream().forEach(obsImage -> {
          delete(obsImage, saltApi);
      });


serverActions.forEach(serverAction ->
              serverAction.getServer().asMinionServer().map(minion -> running.get(minion.getMinionId()))
                      .ifPresent(r -> {
                          r.consume(error -> LOG.error(error.toString()),
                          runningInfos -> ActionFactory.save(updateMinionActionStatus(serverAction, runningInfos)));
                 })
      );