SonarCloud remove candidate rule: java:S1643 Strings should not be concatenated using '+' in a loop

[CDellaGiusta]

This poll closes Friday, April 18th 2025.

Candidate rule for removal: java:S1643
Number of issues with this rule in Uyuni: 17
Rule: Strings should not be concatenated using '+' in a loop
Software qualities impacted: MAINTAINABILITY
Why is this an issue:

Strings are immutable objects, so concatenation doesn’t simply add the new String to the end of the existing string. Instead, in each loop iteration, the first String is converted to an intermediate object type, the second string is appended, and then the intermediate object is converted back to a String. Further, performance of these intermediate operations degrades as the String gets longer. Therefore, the use of StringBuilder is preferred.

Should it be removed?:
There may be simple cases where some trivial concatenations could be clearer tham using the builder class

All rule issues in Uyuni: https://sonarcloud.io/project/issues?languages=java&issueStatuses=OPEN%2CCONFIRMED&id=uyuni-project_uyuni&rules=java%3AS1643

Examples in our code:

for (ValidatorError error : errors) {
              errorString += "<li>" + error.getLocalizedMessage() + "</li>";
}


      for (Object oIn : map.keySet()) {
          String key = (String) oIn;
          if (!validKeys.contains(key)) {
              if (errors == null) {
                  errors = new String(key);
              }
              else {
                  errors += ", " + key;
              }
          }


      while (version < 11) {
          files += "\n" + baseStr + version++;
      }