Correctly propagate error in AuthenticationReader readBuffer

xiaokangwang · xiaokangwang · commit 87affb11a52b · 2024-03-04T19:13:58.000Z
diff --git a/common/crypto/auth.go b/common/crypto/auth.go
@@ -181,7 +181,7 @@ func (r *AuthenticationReader) readInternal(soft bool, mb *buf.MultiBuffer) erro
 	if size <= buf.Size {
 		b, err := r.readBuffer(effectiveSize, int32(padding))
 		if err != nil {
-			return nil
+			return err
 		}
 		*mb = append(*mb, b)
 		return nil

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ func (r AuthenticationReader) readInternal(soft bool, mb buf.MultiBuffer) erro`
`181`	`181`	`if size <= buf.Size {`
`182`	`182`	`b, err := r.readBuffer(effectiveSize, int32(padding))`
`183`	`183`	`if err != nil {`
`184`		`- return nil`
	`184`	`+ return err`
`185`	`185`	`}`
`186`	`186`	`mb = append(mb, b)`
`187`	`187`	`return nil`