Merge pull request #621 from v3io/development

[IG-19529] clear session token and paswword so it won't get logged (#…

Author: dinal

backends/kv/backend.go

@@ -119,10 +119,6 @@ func (b *Backend) updateItem(request *frames.ExecRequest) error {
 
 func (b *Backend) newConnection(session *frames.Session, password string, token string, path string, addSlash bool) (v3io.Container, string, error) {
 
-	// Copy the session to avoid populating the session we received with credentials that may get logged later.
-	newSession := *session
-	session = &newSession
-
 	session = frames.InitSessionDefaults(session, b.framesConfig)
 	containerName, newPath, err := v3ioutils.ProcessPaths(session, path, addSlash)
 	if err != nil {
@@ -137,6 +133,10 @@ func (b *Backend) newConnection(session *frames.Session, password string, token
 		token,
 		b.logger)
 
+	// clear token and password so we won't accidentally log it in the future
+	session.Token = ""
+	session.Password = ""
+
 	if err == nil && b.numWorkers == 0 {
 		resp, err := container.GetClusterMDSync(&v3io.GetClusterMDInput{})
 		if err != nil {

backends/kv/reader.go

@@ -76,17 +76,6 @@ func (kv *Backend) Read(request *frames.ReadRequest) (frames.FrameIterator, erro
 		return nil, err
 	}
 
-	// Create a new platform (v3io) connection with specific RequestChannel length
-	container, tablePath, err = kv.newConnection(request.Proto.Session,
-		request.Password.Get(),
-		request.Token.Get(),
-		request.Proto.Table,
-		true)
-
-	if err != nil {
-		return nil, err
-	}
-
 	input := v3io.GetItemsInput{Filter: request.Proto.Filter, AttributeNames: columns, SortKeyRangeStart: request.Proto.SortKeyRangeStart, SortKeyRangeEnd: request.Proto.SortKeyRangeEnd}
 	kv.logger.DebugWith("read input", "input", input, "request", request)