IsEmpty unit tests

Author: weilerN

pkg/ingressCache/ingressCache_test.go

@@ -5,6 +5,7 @@ import (
 
 	"github.com/v3io/scaler/pkg/ingressCache/mock"
 
+	"github.com/nuclio/errors"
 	"github.com/nuclio/logger"
 	nucliozap "github.com/nuclio/zap"
 	"github.com/stretchr/testify/suite"
@@ -151,12 +152,20 @@ func (suite *IngressCacheTest) TestSet() {
 }
 
 func (suite *IngressCacheTest) TestDelete() {
+	type getFunctionAfterDeleteArgs struct { // this struct enables multiple get tests after delete
+		args           testIngressCacheArgs
+		expectedResult []string
+		shouldFail     bool
+		errorMessage   string
+	}
+
 	for _, testCase := range []struct {
-		name         string
-		args         testIngressCacheArgs
-		shouldFail   bool
-		errorMessage string
-		testMocks    mockFunction
+		name               string
+		args               testIngressCacheArgs
+		shouldFail         bool
+		errorMessage       string
+		testMocks          mockFunction
+		getAfterDeleteArgs []getFunctionAfterDeleteArgs
 	}{
 		{
 			name: "Delete not existed host",
@@ -165,13 +174,55 @@ func (suite *IngressCacheTest) TestDelete() {
 				return nil
 			}, // nil is used to check for non-existing host
 		}, {
-			name: "Delete existed host and path",
+			name: "Delete last function in host, validate host deletion",
 			args: testIngressCacheArgs{testHost, testPath, testFunctionName2},
 			testMocks: func() *mock.SafeTrie {
 				m := &mock.SafeTrie{}
 				m.On("DeleteFunctionName", testPath, testFunctionName2).Return(nil).Once()
+				m.On("IsEmpty").Return(true).Once()
 				return m
 			},
+			getAfterDeleteArgs: []getFunctionAfterDeleteArgs{
+				{
+					args:           testIngressCacheArgs{testHost, testPath, testFunctionName1},
+					expectedResult: nil,
+					shouldFail:     true,
+					errorMessage:   "host does not exist",
+				},
+			},
+		}, {
+			name: "Fail to delete and validate host wasn't deleted",
+			args: testIngressCacheArgs{testHost, testPath, testFunctionName2},
+			testMocks: func() *mock.SafeTrie {
+				m := &mock.SafeTrie{}
+				m.On("DeleteFunctionName", testPath, testFunctionName2).Return(errors.New("mock error")).Once()
+				m.On("GetFunctionName", testPath).Return([]string{testFunctionName2}, nil).Once()
+				return m
+			},
+			getAfterDeleteArgs: []getFunctionAfterDeleteArgs{
+				{
+					args:           testIngressCacheArgs{testHost, testPath, testFunctionName2},
+					expectedResult: []string{testFunctionName2},
+				},
+			},
+			shouldFail:   true,
+			errorMessage: "cache delete failed",
+		}, {
+			name: "Delete not last function in path and validate host wasn't deleted",
+			args: testIngressCacheArgs{testHost, testPath, testFunctionName2},
+			testMocks: func() *mock.SafeTrie {
+				m := &mock.SafeTrie{}
+				m.On("DeleteFunctionName", testPath, testFunctionName2).Return(nil).Once()
+				m.On("IsEmpty").Return(false).Once()
+				m.On("GetFunctionName", testPath).Return([]string{testFunctionName1}, nil).Once()
+				return m
+			},
+			getAfterDeleteArgs: []getFunctionAfterDeleteArgs{
+				{
+					args:           testIngressCacheArgs{testHost, testPath, testFunctionName1},
+					expectedResult: []string{testFunctionName1},
+				},
+			},
 		},
 	} {
 		suite.Run(testCase.name, func() {
@@ -184,6 +235,18 @@ func (suite *IngressCacheTest) TestDelete() {
 			} else {
 				suite.Require().NoError(err)
 			}
+
+			// After delete, check that the expected paths and functions are still there
+			for _, getAfterDeleteArgs := range testCase.getAfterDeleteArgs {
+				result, err := suite.ingressCache.Get(getAfterDeleteArgs.args.host, getAfterDeleteArgs.args.path)
+				if getAfterDeleteArgs.shouldFail {
+					suite.Require().Error(err)
+					suite.Require().Contains(err.Error(), getAfterDeleteArgs.errorMessage)
+				} else {
+					suite.Require().NoError(err)
+					suite.Require().Equal(getAfterDeleteArgs.expectedResult, result)
+				}
+			}
 		})
 	}
 }

pkg/ingressCache/mock/safeTrie.go

@@ -93,3 +93,17 @@ func (_m *SafeTrie) SetFunctionName(path string, function string) error {
 
 	return r0
 }
+
+//nolint:gocritic // this function is being generated by mockery
+func (_m *SafeTrie) IsEmpty() bool {
+	ret := _m.Called()
+
+	var r0 bool
+	if rf, ok := ret.Get(0).(func() bool); ok {
+		r0 = rf()
+	} else {
+		r0 = ret.Get(0).(bool)
+	}
+
+	return r0
+}

pkg/ingressCache/safeTrie_test.go

@@ -406,6 +406,31 @@ func (suite *SafeTrieTest) TestPathTreeDelete() {
 		})
 	}
 }
+func (suite *SafeTrieTest) TestPathTreeIsEmpty() {
+	for _, testCase := range []struct {
+		initialState   []safeTrieFunctionArgs // initial state of the path tree before delete
+		name           string
+		expectedResult bool
+	}{
+		{
+			name:           "is empty with empty trie",
+			expectedResult: true,
+		}, {
+			name:           "is empty with not empty trie",
+			expectedResult: false,
+			initialState: []safeTrieFunctionArgs{
+				{testPath, testFunctionName1},
+			},
+		},
+	} {
+		suite.Run(testCase.name, func() {
+			suite.SetupSubTest(testCase.initialState)
+
+			result := suite.safeTrie.IsEmpty()
+			suite.Require().Equal(testCase.expectedResult, result)
+		})
+	}
+}
 
 // --- SafeTrieTest suite methods ---