Merge 0.4.x to development (#57)

Author: liranbg

.github/workflows/ci.yaml

@@ -21,15 +21,17 @@ jobs:
     name: Lint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
-      - uses: actions/setup-go@v2
+      - uses: actions/setup-go@v3
         with:
-          go-version: "1.14"
+          go-version: "1.17"
 
-      - uses: actions/cache@v2
+      - uses: actions/cache@v3
         with:
-          path: ~/go/pkg/mod
+          path: |
+            ~/.cache/go-build
+            ~/go/pkg/mod
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-
@@ -41,15 +43,17 @@ jobs:
     name: Test
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
-      - uses: actions/setup-go@v2
+      - uses: actions/setup-go@v3
         with:
-          go-version: "1.14"
+          go-version: "1.17"
 
-      - uses: actions/cache@v2
+      - uses: actions/cache@v3
         with:
-          path: ~/go/pkg/mod
+          path: |
+            ~/.cache/go-build
+            ~/go/pkg/mod
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-
@@ -61,15 +65,17 @@ jobs:
     name: Build docker images
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
-      - uses: actions/setup-go@v2
+      - uses: actions/setup-go@v3
         with:
-          go-version: "1.14"
+          go-version: "1.17"
 
-      - uses: actions/cache@v2
+      - uses: actions/cache@v3
         with:
-          path: ~/go/pkg/mod
+          path: |
+            ~/.cache/go-build
+            ~/go/pkg/mod
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-

.github/workflows/release.yaml

@@ -62,15 +62,17 @@ jobs:
         run: |
           echo "SCALER_LABEL=${{ steps.release_info.outputs.REF_TAG }}" >> $GITHUB_ENV
 
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
-      - uses: actions/setup-go@v2
+      - uses: actions/setup-go@v3
         with:
-          go-version: "1.14"
+          go-version: "1.17"
 
-      - uses: actions/cache@v2
+      - uses: actions/cache@v3
         with:
-          path: ~/go/pkg/mod
+          path: |
+            ~/.cache/go-build
+            ~/go/pkg/mod
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-

.golangci.yml

@@ -18,10 +18,9 @@ linters:
     - deadcode
     - goconst
     - gofmt
-    - golint
+    - revive
     - gosimple
     - ineffassign
-    - interfacer
     - misspell
     - staticcheck
     - unconvert
@@ -30,8 +29,8 @@ linters:
     - vetshadow
     - errcheck
     - govet
-    - structcheck
     - typecheck
+    - gocritic
 
 run:
 
@@ -45,10 +44,3 @@ issues:
     - "comment on"
     - "error should be the last"
     - "should have comment"
-
-  exclude-rules:
-
-    # list of excluded linters applied on test files
-    - path: _test\.go
-      linters:
-        - goconst

Makefile

@@ -81,7 +81,7 @@ lint: modules
 			| tr -d \" \
 			| wget -O $(GOPATH)/bin/impi -qi -
 	@test -e $(GOPATH)/bin/golangci-lint || \
-	  	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GOPATH)/bin v1.24.0
+    	  	(curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GOPATH)/bin v1.41.1)
 
 	@echo Verifying imports...
 	chmod +x $(GOPATH)/bin/impi && $(GOPATH)/bin/impi \
@@ -101,7 +101,7 @@ fmt:
 
 .PHONY: test-undockerized
 test-undockerized: modules
-	go test -v ./pkg/... -p 1
+	go test -race -v ./pkg/... -p 1
 
 .PHONY: test
 test:

cmd/autoscaler/Dockerfile

@@ -12,7 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-FROM golang:1.14.3-alpine3.11 AS builder
+
+FROM gcr.io/iguazio/golang:1.17-alpine3.15 AS builder
 
 RUN apk --update --no-cache add \
     git \
@@ -29,6 +30,6 @@ COPY . .
 
 RUN GOOS=linux GOARCH=amd64 go build -a -installsuffix cgo -ldflags="-s -w" -o autoscaler cmd/autoscaler/main.go
 
-FROM alpine:3.11
+FROM gcr.io/iguazio/alpine:3.16
 
 COPY --from=builder /autoscaler/autoscaler /home/v3io/bin/autoscaler

cmd/autoscaler/app/autoscaler.go

@@ -17,6 +17,7 @@ illegal under applicable law, and the grant of the foregoing license
 under the Apache 2.0 license is conditioned upon your compliance with
 such restriction.
 */
+
 package app
 
 import (

cmd/autoscaler/main.go

@@ -17,6 +17,7 @@ illegal under applicable law, and the grant of the foregoing license
 under the Apache 2.0 license is conditioned upon your compliance with
 such restriction.
 */
+
 package main
 
 import (

cmd/dlx/Dockerfile

@@ -12,7 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-FROM golang:1.14.3-alpine3.11 AS builder
+
+FROM gcr.io/iguazio/golang:1.17-alpine3.15 AS builder
 
 RUN apk --update --no-cache add \
     git \
@@ -29,6 +30,6 @@ COPY . .
 
 RUN GOOS=linux GOARCH=amd64 go build -a -installsuffix cgo -ldflags="-s -w" -o dlx cmd/dlx/main.go
 
-FROM alpine:3.11
+FROM gcr.io/iguazio/alpine:3.16
 
 COPY --from=builder /dlx/dlx /home/v3io/bin/dlx

cmd/dlx/app/dlx.go

@@ -17,6 +17,7 @@ illegal under applicable law, and the grant of the foregoing license
 under the Apache 2.0 license is conditioned upon your compliance with
 such restriction.
 */
+
 package app
 
 import (

cmd/dlx/main.go

@@ -17,6 +17,7 @@ illegal under applicable law, and the grant of the foregoing license
 under the Apache 2.0 license is conditioned upon your compliance with
 such restriction.
 */
+
 package main
 
 import (