[DLX] Support root path when resolving URL#81
Merged
TomerShor merged 2 commits intov3io:developmentfrom Sep 17, 2025
Merged
Conversation
rokatyy
approved these changes
Sep 17, 2025
TomerShor
approved these changes
Sep 17, 2025
4 tasks
rokatyy
pushed a commit
to nuclio/nuclio
that referenced
this pull request
Sep 17, 2025
### 📝 Description Bump Scaler version to v0.10.1 --- ### 🛠️ Changes Made updated `go.mod` --- ### ✅ Checklist - [ ] I updated the documentation (if applicable) - [x] I have tested the changes in this PR --- ### 🧪 Testing - Did dev QA as part of v3io/scaler#81 --- ### 🔗 References - Ticket link: https://iguazio.atlassian.net/browse/NUC-597 - Design docs links: - External links: --- ### 🚨 Breaking Changes? - [ ] Yes (explain below) - [x] No <!-- If yes, describe what needs to be changed downstream: --> --- ### 🔍️ Additional Notes <!-- Anything else reviewers should know (follow-up tasks, known issues, affected areas etc.). --> <!-- ### 📸 Screenshots / Logs -->
weilerN
added a commit
to weilerN/nuclio
that referenced
this pull request
Sep 18, 2025
### 📝 Description Bump Scaler version to v0.10.1 --- ### 🛠️ Changes Made updated `go.mod` --- ### ✅ Checklist - [ ] I updated the documentation (if applicable) - [x] I have tested the changes in this PR --- ### 🧪 Testing - Did dev QA as part of v3io/scaler#81 --- ### 🔗 References - Ticket link: https://iguazio.atlassian.net/browse/NUC-597 - Design docs links: - External links: --- ### 🚨 Breaking Changes? - [ ] Yes (explain below) - [x] No <!-- If yes, describe what needs to be changed downstream: --> --- ### 🔍️ Additional Notes <!-- Anything else reviewers should know (follow-up tasks, known issues, affected areas etc.). --> <!-- ### 📸 Screenshots / Logs -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR handles the case where the closest common prefix of a request and the existing ingress is the root path (i.e.
\).🛠️ Changes Made
✅ Checklist
🧪 Testing
🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes
📸 Screenshots / Logs