how empty members when no consumer group ready (#6)

Co-authored-by: pavius-poc <36161574+pavius-poc@users.noreply.github.com>

Author: pavius

go.mod

@@ -14,5 +14,5 @@ require (
 	github.com/spf13/cobra v0.0.3
 	github.com/spf13/pflag v1.0.3 // indirect
 	github.com/v3io/registry v0.0.1
-	github.com/v3io/v3io-go v0.1.2
+	github.com/v3io/v3io-go v0.1.4
 )

go.sum

@@ -69,8 +69,8 @@ github.com/tinylib/msgp v1.1.1 h1:TnCZ3FIuKeaIy+F45+Cnp+caqdXGy4z74HvwXN+570Y=
 github.com/tinylib/msgp v1.1.1/go.mod h1:+d+yLhGm8mzTaHzB+wgMYrodPfmZrzkirds8fDWklFE=
 github.com/v3io/registry v0.0.1 h1:tVOEMTDI6tuNNs7escRvdf9j8srC+XtP6ryKvEcG9LA=
 github.com/v3io/registry v0.0.1/go.mod h1:QJ7/XZqI5Yd7vupSm/GXJsyyajeTTEIPSoKJQBk7wuE=
-github.com/v3io/v3io-go v0.1.2 h1:YdnqB+l+exykUeW2YVCrGSIdLL2p/lmmiBvfhNM9UQ0=
-github.com/v3io/v3io-go v0.1.2/go.mod h1:D0W1tjsVgcp4xk3ZI2fjKTKaOpYJLewN1BPN0x2osO4=
+github.com/v3io/v3io-go v0.1.4 h1:zg/B0ATSxaLm0/Z7nNnlyrCtDQTIBTSoaIo2wKnKx+M=
+github.com/v3io/v3io-go v0.1.4/go.mod h1:D0W1tjsVgcp4xk3ZI2fjKTKaOpYJLewN1BPN0x2osO4=
 github.com/valyala/bytebufferpool v1.0.0 h1:GqA5TC/0021Y/b9FG4Oi9Mr3q7XYx6KllzawFIhcdPw=
 github.com/valyala/bytebufferpool v1.0.0/go.mod h1:6bBcMArwyJ5K/AmCkWv1jt77kVWyCJ6HpOuEn7z0Csc=
 github.com/valyala/fasthttp v1.2.0 h1:dzZJf2IuMiclVjdw0kkT+f9u4YdrapbNyGAN47E/qnk=

pkg/v3ctl/root.go

@@ -131,8 +131,7 @@ func (c *RootCommandeer) Initialize() error {
 	}
 
 	c.DataPlaneContext, err = v3iohttp.NewContext(c.Logger,
-		v3iohttp.NewDefaultClient(),
-		&v3io.NewContextInput{})
+		&v3iohttp.NewContextInput{})
 	if err != nil {
 		return errors.Wrap(err, "Failed to create v3io context")
 	}

pkg/v3ctl/stream/getconsumergroupmembers.go

@@ -6,6 +6,7 @@ import (
 	"github.com/nuclio/errors"
 	"github.com/spf13/cobra"
 	"github.com/v3io/v3io-go/pkg/dataplane/streamconsumergroup"
+	v3ioerrors "github.com/v3io/v3io-go/pkg/errors"
 )
 
 type getStreamConsumerGroupMembersCommandeer struct {
@@ -48,6 +49,16 @@ func newGetStreamConsumerGroupMembersCommandeer(getStreamConsumerGroupCommandeer
 
 			streamConsumerGroupState, err := streamConsumerGroup.GetState()
 			if err != nil {
+				if errors.Cause(err) == v3ioerrors.ErrNotFound {
+					if err := commandeer.RootCommandeer.Render([]string{},
+						[]string{"Member ID", "Last Heartbeat", "Shards"},
+						[][]string{}); err != nil {
+						return errors.Wrap(err, "Failed to render")
+					}
+
+					return nil
+				}
+
 				return errors.Wrap(err, "Failed to get consumer group state")
 			}
 

pkg/v3ctl/stream/getconsumergroupoffsets.go

@@ -40,13 +40,13 @@ func newGetStreamConsumerGroupOffsetsCommandeer(getStreamConsumerGroupCommandeer
 				return errors.Wrap(err, "Failed to initialize root")
 			}
 
-			shardOffets, err := commandeer.getShardOffets(args[0])
+			shardOffsets, err := commandeer.getShardOffets(args[0])
 			if err != nil {
 				return errors.Wrap(err, "Failed to get shard offsets")
 			}
 
 			var records [][]string
-			for _, shardOffset := range shardOffets {
+			for _, shardOffset := range shardOffsets {
 				memberID := shardOffset.MemberID
 				if memberID == "" {
 					memberID = "-"
@@ -59,7 +59,7 @@ func newGetStreamConsumerGroupOffsetsCommandeer(getStreamConsumerGroupCommandeer
 				})
 			}
 
-			if err := commandeer.RootCommandeer.Render(shardOffets,
+			if err := commandeer.RootCommandeer.Render(shardOffsets,
 				[]string{"Shard ID", "Member ID", "Offset"},
 				records); err != nil {
 				return errors.Wrap(err, "Failed to render")