Include full HTTP response in error. (#20)

Gal Topper · pavius · commit 9441f7c028db · 2019-06-06T11:27:07.000+03:00
diff --git a/pkg/dataplane/http/context.go b/pkg/dataplane/http/context.go
@@ -923,7 +923,7 @@ func (c *context) sendRequest(dataPlaneInput *v3io.DataPlaneInput,
 
 	// make sure we got expected status
 	if !success {
-		err = v3ioerrors.NewErrorWithStatusCode(fmt.Errorf("Failed %s with status %d", method, statusCode), statusCode)
+		err = v3ioerrors.NewErrorWithStatusCode(fmt.Errorf("Expected a 2xx response status code: %s", response.HTTPResponse.String()), statusCode)
 		goto cleanup
 	}
 
diff --git a/pkg/errors/errors.go b/pkg/errors/errors.go
@@ -2,7 +2,6 @@ package v3ioerrors
 
 import (
 	"errors"
-	"fmt"
 )
 
 var ErrInvalidTypeConversion = errors.New("Invalid type conversion")
@@ -26,5 +25,5 @@ func (e ErrorWithStatusCode) StatusCode() int {
 }
 
 func (e ErrorWithStatusCode) Error() string {
-	return fmt.Sprintf("%s (%d response code)", e.error.Error(), e.statusCode)
+	return e.error.Error()
 }

Original file line number	Diff line number	Diff line change
`@@ -923,7 +923,7 @@ func (c context) sendRequest(dataPlaneInput v3io.DataPlaneInput,`
`923`	`923`
`924`	`924`	`// make sure we got expected status`
`925`	`925`	`if !success {`
`926`		`- err = v3ioerrors.NewErrorWithStatusCode(fmt.Errorf("Failed %s with status %d", method, statusCode), statusCode)`
	`926`	`+ err = v3ioerrors.NewErrorWithStatusCode(fmt.Errorf("Expected a 2xx response status code: %s", response.HTTPResponse.String()), statusCode)`
`927`	`927`	`goto cleanup`
`928`	`928`	`}`
`929`	`929`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,6 @@ package v3ioerrors`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"errors"`
`5`		`- "fmt"`
`6`	`5`	`)`
`7`	`6`
`8`	`7`	`var ErrInvalidTypeConversion = errors.New("Invalid type conversion")`
`@@ -26,5 +25,5 @@ func (e ErrorWithStatusCode) StatusCode() int {`
`26`	`25`	`}`
`27`	`26`
`28`	`27`	`func (e ErrorWithStatusCode) Error() string {`
`29`		`- return fmt.Sprintf("%s (%d response code)", e.error.Error(), e.statusCode)`
	`28`	`+ return e.error.Error()`
`30`	`29`	`}`