fix metric.lock race (#544) (#545)

dinal · Dina Nimrodi · web-flow · commit 61706a361036 · 2020-12-03T15:04:51.000+02:00
Co-authored-by: Dina Nimrodi &lt;dinan@iguazio.com&gt;

Co-authored-by: Dina Nimrodi &lt;dinan@iguazio.com&gt;
diff --git a/pkg/appender/appender.go b/pkg/appender/appender.go
@@ -186,8 +186,8 @@ func (mc *MetricsCache) addMetric(hash uint64, name string, metric *MetricState)
 // Push append to async channel
 func (mc *MetricsCache) appendTV(metric *MetricState, t int64, v interface{}) {
 	metric.Lock()
-	defer metric.Unlock()
 	metric.store.numNotProcessed++
+	metric.Unlock()
 	mc.asyncAppendChan <- &asyncAppend{metric: metric, t: t, v: v}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -186,8 +186,8 @@ func (mc MetricsCache) addMetric(hash uint64, name string, metric MetricState)`
`186`	`186`	`// Push append to async channel`
`187`	`187`	`func (mc MetricsCache) appendTV(metric MetricState, t int64, v interface{}) {`
`188`	`188`	`metric.Lock()`
`189`		`- defer metric.Unlock()`
`190`	`189`	`metric.store.numNotProcessed++`
	`190`	`+ metric.Unlock()`
`191`	`191`	`mc.asyncAppendChan <- &asyncAppend{metric: metric, t: t, v: v}`
`192`	`192`	`}`
`193`	`193`