Skip to content

feat: add focusSelectedItem flag to combo-box #9194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DiegoCardoso wants to merge 4 commits into
base: fix/combo-box/connector-range-management
Choose a base branch
from

chore(combo-box): trim review-narrative comments in focusSelectedItem

ee8cb4c
Select commit
Loading
Failed to load commit list.
Draft

feat: add focusSelectedItem flag to combo-box #9194

chore(combo-box): trim review-narrative comments in focusSelectedItem
ee8cb4c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 30, 2026 in 3m 31s

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 334 in vaadin-combo-box-flow-parent/vaadin-combo-box-flow-integration-tests/src/test/java/com/vaadin/flow/component/combobox/test/ComboBoxFocusSelectedItemIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow-components&issues=AZ3P4u4JXgM4KRTOfvQ9&open=AZ3P4u4JXgM4KRTOfvQ9&pullRequest=9194

Check failure on line 237 in vaadin-combo-box-flow-parent/vaadin-combo-box-flow-integration-tests/src/test/java/com/vaadin/flow/component/combobox/test/ComboBoxFocusSelectedItemIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow-components&issues=AZ3P4u4JXgM4KRTOfvQ5&open=AZ3P4u4JXgM4KRTOfvQ5&pullRequest=9194

Check warning on line 247 in vaadin-combo-box-flow-parent/vaadin-combo-box-flow-integration-tests/src/main/java/com/vaadin/flow/component/combobox/test/ComboBoxFocusSelectedItemPage.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define the locale to be used in this String operation. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow-components&issues=AZ3ATNAvgk1YJVedfXLt&open=AZ3ATNAvgk1YJVedfXLt&pullRequest=9194

Check warning on line 245 in vaadin-combo-box-flow-parent/vaadin-combo-box-flow-integration-tests/src/main/java/com/vaadin/flow/component/combobox/test/ComboBoxFocusSelectedItemPage.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define the locale to be used in this String operation. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow-components&issues=AZ3ATNAvgk1YJVedfXLs&open=AZ3ATNAvgk1YJVedfXLs&pullRequest=9194

Check warning on line 126 in vaadin-combo-box-flow-parent/vaadin-combo-box-flow-integration-tests/src/test/java/com/vaadin/flow/component/combobox/test/ComboBoxFocusSelectedItemIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Thread.sleep()". 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow-components&issues=AZ3ATNFcgk1YJVedfXL1&open=AZ3ATNFcgk1YJVedfXL1&pullRequest=9194

Check warning on line 164 in vaadin-combo-box-flow-parent/vaadin-combo-box-flow-integration-tests/src/main/java/com/vaadin/flow/component/combobox/test/ComboBoxFocusSelectedItemPage.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow-components&issues=AZ3ATNAvgk1YJVedfXLr&open=AZ3ATNAvgk1YJVedfXLr&pullRequest=9194

Check failure on line 252 in vaadin-combo-box-flow-parent/vaadin-combo-box-flow-integration-tests/src/test/java/com/vaadin/flow/component/combobox/test/ComboBoxFocusSelectedItemIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow-components&issues=AZ3P4u4JXgM4KRTOfvQ6&open=AZ3P4u4JXgM4KRTOfvQ6&pullRequest=9194

Check failure on line 265 in vaadin-combo-box-flow-parent/vaadin-combo-box-flow-integration-tests/src/test/java/com/vaadin/flow/component/combobox/test/ComboBoxFocusSelectedItemIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow-components&issues=AZ3P4u4JXgM4KRTOfvQ7&open=AZ3P4u4JXgM4KRTOfvQ7&pullRequest=9194

Check failure on line 274 in vaadin-combo-box-flow-parent/vaadin-combo-box-flow-integration-tests/src/test/java/com/vaadin/flow/component/combobox/test/ComboBoxFocusSelectedItemIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow-components&issues=AZ3P4u4JXgM4KRTOfvQ8&open=AZ3P4u4JXgM4KRTOfvQ8&pullRequest=9194

Check warning on line 469 in vaadin-combo-box-flow-parent/vaadin-combo-box-flow/src/main/java/com/vaadin/flow/component/combobox/ComboBox.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either log or rethrow this exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow-components&issues=AZ3ATNFxgk1YJVedfXL2&open=AZ3ATNFxgk1YJVedfXL2&pullRequest=9194
View more details on SonarQubeCloud