PiT 25.0: errors running the mpr-demo project

[manolo]

Description of the bug

1. Install a valid V8 Spreadsheet license in ~/vaadin.spreadsheet.developer.license

2. Run the project

   ## Cloning repository vaadin/mpr-demo
   git clone -q git@github.com:vaadin/mpr-demo.git
   cd mpr-demo
   ## Changing Maven property vaadin.version 25.0.0-alpha14 in pom.xml
   perl -pi -e 's|(\s*<'vaadin.version'>)[^\s]+(</'vaadin.version'>)|${1}25.0.0-alpha14${2}|g' pom.xml
   ## Changing Maven property flow.version 25.0.0-alpha20 in pom.xml
   perl -pi -e 's|(\s*<'flow.version'>)[^\s]+(</'flow.version'>)|${1}25.0.0-alpha20${2}|g' pom.xml
   ## Changing Maven property mpr.version  8.0.0-alpha2 in pom.xml
   perl -pi -e 's|(\s*<'mpr.version'>)[^\s]+(</'mpr.version'>)|${1}8.0.0-alpha2${2}|g' pom.xml
   ## Run the project
   mvn -ntp -B jetty:run

3. See the errors

java.lang.IllegalArgumentException: Unable to create an instance of 'org.vaadin.mprdemo.SpreadsheetView'. The constructor threw an exception.
	at com.vaadin.flow.internal.ReflectTools.convertInstantiationException(ReflectTools.java:540)

...

Caused by: java.lang.NoClassDefFoundError: org/apache/poi/hssf/converter/ExcelToHtmlUtils
	at com.vaadin.addon.spreadsheet.SpreadsheetFactory.setDefaultColumnWidth(SpreadsheetFactory.java:1093)
	at com.vaadin.addon.spreadsheet.SpreadsheetFactory.reloadSpreadsheetData(SpreadsheetFactory.java:397)
	at com.vaadin.addon.spreadsheet.SpreadsheetFactory.generateNewSpreadsheet(SpreadsheetFactory.java:381)
	at com.vaadin.addon.spreadsheet.SpreadsheetFactory.loadSpreadsheetWith(SpreadsheetFactory.java:143)
	at com.vaadin.addon.spreadsheet.Spreadsheet.<init>(Spreadsheet.java:430)
	at com.vaadin.addon.spreadsheet.Spreadsheet.<init>(Spreadsheet.java:411)
	at org.vaadin.mprdemo.SpreadsheetView.initSpreadsheet(SpreadsheetView.java:98)
	at org.vaadin.mprdemo.SpreadsheetView.<init>(SpreadsheetView.java:45)

Expected behavior

.

Minimal reproducible example

see description

Versions

• Vaadin : 25.0.0-alpha14
• Flow version: 25.0.0-alpha20
• MPR: 8.0.0-alpha2

[manolo]

Seems that ExcelToHtmlUtils was included in org.apache.poi:poi-scratchpad:jar:4.0.1 but not in org.apache.poi:poi-scratchpad:jar:5.4.1 which is used in the project now.

The dependencies are in 24.9

[INFO] +- com.vaadin:vaadin-spreadsheet:jar:3.0.0.alpha1:compile
[INFO] |  +- com.vaadin:vaadin-client-compiled:jar:8.0.0:compile
[INFO] |  +- org.apache.poi:poi:jar:4.0.1:compile
[INFO] |  |  +- commons-codec:commons-codec:jar:1.11:compile
[INFO] |  |  +- org.apache.commons:commons-collections4:jar:4.2:compile
[INFO] |  |  \- org.apache.commons:commons-math3:jar:3.6.1:compile
[INFO] |  +- org.apache.poi:poi-scratchpad:jar:4.0.1:compile
[INFO] |  +- org.apache.poi:poi-ooxml:jar:4.0.1:compile
[INFO] |  |  +- org.apache.poi:poi-ooxml-schemas:jar:4.0.1:compile
[INFO] |  |  +- org.apache.commons:commons-compress:jar:1.18:compile
[INFO] |  |  \- com.github.virtuald:curvesapi:jar:1.05:compile
[INFO] |  \- org.apache.poi:ooxml-schemas:jar:1.4:compile
[INFO] |     \- org.apache.xmlbeans:xmlbeans:jar:3.0.1:compile

and in 25.0

[INFO] +- com.vaadin:vaadin-spreadsheet:jar:3.0.0.alpha1:compile
[INFO] |  +- com.vaadin:vaadin-client-compiled:jar:8.0.0:compile
[INFO] |  +- org.apache.poi:poi:jar:5.4.1:compile
[INFO] |  |  +- commons-codec:commons-codec:jar:1.18.0:compile
[INFO] |  |  +- org.apache.commons:commons-collections4:jar:4.4:compile
[INFO] |  |  +- org.apache.commons:commons-math3:jar:3.6.1:compile
[INFO] |  |  +- commons-io:commons-io:jar:2.20.0:compile
[INFO] |  |  +- com.zaxxer:SparseBitSet:jar:1.3:compile
[INFO] |  |  \- org.apache.logging.log4j:log4j-api:jar:2.24.3:compile
[INFO] |  +- org.apache.poi:poi-scratchpad:jar:5.4.1:compile
[INFO] |  +- org.apache.poi:poi-ooxml:jar:5.4.1:compile
[INFO] |  |  +- org.apache.poi:poi-ooxml-lite:jar:5.4.1:compile
[INFO] |  |  +- org.apache.xmlbeans:xmlbeans:jar:5.3.0:compile
[INFO] |  |  +- org.apache.commons:commons-compress:jar:1.27.1:compile
[INFO] |  |  \- com.github.virtuald:curvesapi:jar:1.08:compile
[INFO] |  \- org.apache.poi:ooxml-schemas:jar:1.4:compile

The question is why vaadin overrides the version of POI?

[mcollovati]

poi 5.4.1 seems to come from com.vaadin:vaadin-flow-components

[ZheSun88]

yes.. flow-component has the poi dependency in the dependencyMangement
https://github.com/vaadin/flow-components/blob/9679df0d32e70f67de488e9273860931281a1606/pom.xml#L211

and why it happend now, this is because we start to use the flow-components-bom in Vaadin 25, which has the parent as vaadin-flow-components

[manolo]

So there are two options:

• bump poi version in v8 addon (needs some extra work to fix code)
• remove poi from flow-components bom, and it's vaadin-spreadsheet that brings the correct poi-version when it's used