No overload matches this call.

[Lars-jnk]

Describe the bug

No overload matches this call. Overload 1 of 3, '(path: string, module: Readonly<Record<string, unknown>>, children?: readonly Readonly<{ path: string; module?: RouteModule | undefined; component?: ComponentType | undefined; config?: Readonly<...> | undefined; children?: readonly Readonly<...>[] | undefined; flowLayout?: boolean | undefined; }>[] | undefined): Readonly<...>', gave the following error. Argument of type 'LazyExoticComponent<(props: DropDownMenuProps) => Element>' is not assignable to parameter of type 'Readonly<Record<string, unknown>>'. Index signature for type 'string' is missing in type 'LazyExoticComponent<(props: DropDownMenuProps) => Element>'. Overload 2 of 3, '(path: string, component: ComponentType, config: Readonly<{ title?: string | undefined; rolesAllowed?: readonly [string, ...string[]] | undefined; loginRequired?: boolean | undefined; ... 5 more ...; detail?: unknown; }> | undefined, children?: readonly Readonly<...>[] | undefined): Readonly<...>', gave the following error. Argument of type 'LazyExoticComponent<(props: DropDownMenuProps) => Element>' is not assignable to parameter of type 'ComponentType'. Type 'LazyExoticComponent<(props: DropDownMenuProps) => Element>' is not assignable to type 'FunctionComponent<{}>'. Types of parameters 'props' and 'props' are incompatible. Type '{}' is missing the following properties from type 'DropDownMenuProps': title, content
/home/lars/dev/cliber/src/main/frontend/generated/file-routes.ts:20:51
18 | createRoute_1("comps", [
19 | createRoute_1("dropDownMenu", [

20 | createRoute_1("DropDownMenu", lazy_1(() => import("../views/components/comps/dropDownMenu/DropDownMenu.js")), { "route": "DropDownMenu", "flowLayout": false, "title": "Drop Down Menu" })
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
21 | ]),
22 | createRoute_1("GroupComp", lazy_1(() => import("../views/components/comps/GroupComp.js")), { "route": "GroupComp", "flowLayout": false, "title": "Group Comp" }),
23 | createRoute_1("language", [

Expected-behavior

No error

Reproduction

update hilla from 28.7.2 to 24.8.3

I don't know anymore. I got back to 24.7.2 and hope, if I try to upgrade hilla the next time, it will work.

System Info

update hilla from 28.7.2 to 24.8.3

[platosha]

Hi, thanks for the issue.

Would it help to remove the src/main/frontend/generated directory during upgrade? It should regenerate automatically on dev server run and production build.

[Lars-jnk]

No, still the same issue.

[cromoteca]

The concerned file looks like a component, not a view. Do you need to access DropDownMenu as a view? If not, try moving your components out of the frontend/views directory.

[KardonskyRoman]

Make sure, you have only view files accessible for menu in views folder. When I was upgrading from 24.7 to 24.8 I had to move all .tsx files from views to components (except for main view files).

[Lars-jnk]

It solved the issue. But you shouldn't force the devs to put there files in a certain directory. I like to have my stuff together and not torn a part.

Now all my Endpoint have a 401. What are you doing? Why there are always such issues when I upgrade your framework? It's so annoying! I open a new issue for that.

[cromoteca]

The file-based router basically takes over the views folder, and the documentation specifies that all .jsx/.tsx files in that folder are considered views. You can of course avoid using the file-based router by creating your own routes.tsx file, but if you are fine using our router, please put non-view files elsewhere. This was also true in 24.7, although the behavior was slightly different and it worked in your case.

[Lars-jnk]

In my opinion using a file based router is a very bad idea and should be avoided.
Yes, it worked in 24.7. I had all my ui file in the views folder. Now stuff the belong together is torn apart. I don't like that. But I have to life with it.

[cromoteca]

But you are not forced to use the file-based router: just define routes.tsx yourself and you can stick to normal React Router, and keep your preferred directory structure.
See https://vaadin.com/docs/latest/hilla/guides/routing#the-routes-tsx-source-file for details.

[Lars-jnk]

Yes, I know and I use the routes.tsx. But I did got that error with that config. So no, I have to use your directory structure. Or I've configurated something wrong. Idk, doing react now for a little bit more the 3 month.
Idk, it works now.

[cromoteca]

Please reopen the issue if you confirm that it's impossible to keep any file you want in /views when not using file-based router.