fix: readAndWriteOutsideSessionLock set always false (#261)

Special error handling of Liferay portlet is not compatible with readAndWriteOutsideSessionLock=true introduced in Flow 23.6.3. See #213.

Author: tltv

pom.xml

@@ -73,9 +73,9 @@
         <maven.resources.plugin.version>3.0.2</maven.resources.plugin.version>
         <maven.clean.plugin.version>3.0.0</maven.clean.plugin.version>
 
-        <testbench.version>8.1.0</testbench.version>
-        <vaadin.version>23.3-SNAPSHOT</vaadin.version>
-        <flow.version>23.3-SNAPSHOT</flow.version>
+        <testbench.version>8.3.0</testbench.version>
+        <vaadin.version>23.6-SNAPSHOT</vaadin.version>
+        <flow.version>23.6-SNAPSHOT</flow.version>
         <flow.cdi.version>14.0-SNAPSHOT</flow.cdi.version>
         <jetty.version>10.0.9</jetty.version>
         <webdrivermanager.version>5.2.3</webdrivermanager.version>

vaadin-portlet-liferay-integration-tests/liferay-tests-generic/src/test/java/com/vaadin/flow/portal/liferay/streamresource/LiferayStreamResourceIT.java

@@ -8,8 +8,8 @@
  */
 package com.vaadin.flow.portal.liferay.streamresource;
 
+import java.time.Duration;
 import java.util.Map;
-import java.util.concurrent.TimeUnit;
 
 import net.jcip.annotations.NotThreadSafe;
 import org.junit.Assert;
@@ -27,7 +27,7 @@ public void downloadStreamResource_responseHeadersAreSent() {
         AnchorElement link = getVaadinPortletRootElement()
                 .$(AnchorElement.class).id("downloadLink");
         String url = link.getAttribute("href");
-        getDriver().manage().timeouts().setScriptTimeout(15, TimeUnit.SECONDS);
+        getDriver().manage().timeouts().scriptTimeout(Duration.ofSeconds(15));
 
         Map<String, String> headers = downloadAndGetResponseHeaders(url);
 

vaadin-portlet/src/main/java/com/vaadin/flow/portal/PortletUidlRequestHandler.java

@@ -41,6 +41,12 @@ public boolean synchronizedHandleRequest(VaadinSession session, VaadinRequest re
         return super.synchronizedHandleRequest(session, request, vaadinResponseWrapper);
     }
 
+    @Override
+    public boolean isReadAndWriteOutsideSessionLock() {
+        // special VaadinResponseWrapper is not compatible with returning true.
+        return false;
+    }
+
     /**
      * Wraps the portlet response to stub the writing actions so as to not
      * write the UIDL sync message, when the error occurs during RPC handling.