Conversation
Member
Artur-
commented
Mar 27, 2026
Artur-
commented
- Use ListSignal.getValues() instead of manual get().stream().map(get())
- Wrap signal modification in effect with runWithoutTransaction() to make the intentional mutation explicit (tracking previous values)
- Use Signal.computed() for multi-signal text binding instead of map() with get() on another signal
- Use ListSignal.getValues() instead of manual get().stream().map(get()) - Wrap signal modification in effect with runWithoutTransaction() to make the intentional mutation explicit (tracking previous values) - Use Signal.computed() for multi-signal text binding instead of map() with get() on another signal
Test that onDataUpdate propagates values to highlight card spans and that the percentage change badge computes correctly after two data updates (exercises the runWithoutTransaction and Signal.computed changes). Made onDataUpdate package-private to enable direct testing.
Artur-
commented
Apr 23, 2026
mshabarov
approved these changes
Apr 23, 2026
Contributor
mshabarov
left a comment
mshabarov
left a comment
There was a problem hiding this comment.
Looks good, but I don't fully get why
Uses runWithoutTransaction since we must track previous state
is needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.