refactor: restructure CI workflow to optimize SauceLabs usage and build times

Completely restructure the validation workflow to separate concerns and
respect SauceLabs concurrent session limits while maximizing parallelism.

## New Job Structure

1. **format-check** - Code style validation (unchanged)
2. **build** - Build entire project once, generate javadoc, cache artifacts
3. **unit-tests** - Run all unit tests using cached build (no SauceLabs)
4. **integration-tests** - Run only SauceLabs browser tests using cached build
   - Matrix: JUnit 4, 5, 6 variants
   - Sequential execution within workflow (max-parallel: 1)
   - Global concurrency control across all PRs

## Key Improvements

**Build once, use everywhere:**
- Build job runs `mvn clean install -DskipTests` once
- Javadoc generated once in build job (not 3x in integration tests)
- Artifacts cached with run-specific key: `github.run_id`
- Both unit-tests and integration-tests restore from cache
- Eliminates redundant builds (was building 3x, once per JUnit version)

**Independent unit test execution:**
- Runs `mvn test` separately from integration tests
- No SauceLabs dependency (fast, cheap, can parallelize)
- Separate test reports: surefire-reports (unit tests)
- Added TestBench license setup for Pro feature validation

**Optimized integration tests:**
- Runs `mvn verify -Dsurefire.skip=true -pl <module> -am -P validation`
- `-Dsurefire.skip=true` skips only unit tests (already ran in separate job)
- Runs only failsafe integration tests (*IT.java files)
- Uses full SauceLabs parallelism: `testsInParallel=5`, `forkCount=5`
- Separate test reports: failsafe-reports (integration tests)
- Removed javadoc generation (moved to build job)

**SauceLabs concurrency control:**
- Job-level concurrency group: `saucelabs-testbench`
- Ensures only one set of integration tests runs globally
- Matrix strategy runs JUnit 4/5/6 sequentially (max-parallel: 1)
- Total concurrent sessions: exactly 5 (within SauceLabs limit)

## Resource Utilization

**Multiple PRs can run in parallel:**
- format-check: ✅ parallel across all PRs
- build: ✅ parallel across all PRs (includes javadoc)
- unit-tests: ✅ parallel across all PRs
- integration-tests: ❌ queued globally (SauceLabs constraint only)

**Performance benefits:**
- Faster feedback: format/build/unit-tests run immediately in parallel
- Faster builds: build once vs 3x (33% of previous time)
- Javadoc generated once vs 3x (67% reduction)
- Better SauceLabs utilization: full 5-session parallelism per test run
- No wasted concurrent sessions from multiple workflows
- Integration tests focus purely on browser testing (no javadoc overhead)

## Maven Cache Strategy

Cache key includes `github.run_id` for per-workflow isolation:
- build job: creates cache with `actions/cache@v4`
- unit-tests job: restores cache with `actions/cache/restore@v4`
- integration-tests job: restores cache with `actions/cache/restore@v4`

Author: Artur-

.github/workflows/validation.yml

@@ -38,17 +38,15 @@ jobs:
       - name: Run formatter validation
         run: mvn formatter:validate --batch-mode --no-transfer-progress
 
-  build-and-test:
-    name: Build and Test
+  build:
+    name: Build Project
     needs: format-check
     runs-on: ubuntu-latest
-    timeout-minutes: 45
+    timeout-minutes: 15
 
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
 
       - name: Set up JDK ${{ env.JAVA_VERSION }}
         uses: actions/setup-java@v4
@@ -65,7 +63,7 @@ jobs:
         uses: actions/cache@v4
         with:
           path: ~/.m2/repository
-          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}-${{ github.run_id }}
           restore-keys: |
             ${{ runner.os }}-maven-
 
@@ -75,6 +73,112 @@ jobs:
           echo "---> Clean maven cache"
           rm -rf ~/.m2/repository ~/.npm* ~/.pnpm*
 
+      - name: Build with Maven and Generate Javadoc
+        run: |
+          mvn clean install -DskipTests -B
+          mvn javadoc:javadoc -Dtestbench.javadocs -B
+
+  unit-tests:
+    name: Unit Tests
+    needs: build
+    runs-on: ubuntu-latest
+    timeout-minutes: 15
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Set up JDK ${{ env.JAVA_VERSION }}
+        uses: actions/setup-java@v4
+        with:
+          java-version: ${{ env.JAVA_VERSION }}
+          distribution: "temurin"
+
+      - name: Restore Maven cache
+        uses: actions/cache/restore@v4
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}-${{ github.run_id }}
+
+      - name: Set TB License
+        run: |
+          TB_LICENSE=${{secrets.TB_LICENSE}}
+          mkdir -p ~/.vaadin/
+          echo '{"username":"'`echo $TB_LICENSE | cut -d / -f1`'","proKey":"'`echo $TB_LICENSE | cut -d / -f2`'"}' > ~/.vaadin/proKey
+
+      - name: Run unit tests
+        run: |
+          mvn test -B
+
+      - name: Upload test reports on failure
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: unit-test-reports-${{ github.run_id }}
+          path: |
+            **/target/surefire-reports/
+          retention-days: 7
+
+      - name: Upload test results
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: unit-test-results-${{ github.run_id }}
+          path: |
+            **/target/surefire-reports/TEST-*.xml
+          retention-days: 7
+
+      - name: Publish unit test results
+        if: always()
+        uses: EnricoMi/publish-unit-test-result-action@v2
+        with:
+          files: |
+            **/target/surefire-reports/TEST-*.xml
+          check_name: Unit Test Results
+          comment_mode: failures
+
+  integration-tests:
+    name: Integration Tests (${{ matrix.name }})
+    needs: build
+    runs-on: ubuntu-latest
+    timeout-minutes: 45
+    concurrency:
+      group: saucelabs-testbench  # Global queue for SauceLabs tests only
+      cancel-in-progress: false
+    strategy:
+      max-parallel: 1  # Only one JUnit version at a time to stay within SauceLabs limit
+      matrix:
+        include:
+          - name: JUnit 4
+            module: vaadin-testbench-integration-tests
+          - name: JUnit 5
+            module: vaadin-testbench-integration-tests-junit5
+          - name: JUnit 6
+            module: vaadin-testbench-integration-tests-junit6
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Set up JDK ${{ env.JAVA_VERSION }}
+        uses: actions/setup-java@v4
+        with:
+          java-version: ${{ env.JAVA_VERSION }}
+          distribution: "temurin"
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+
+      - name: Restore Maven cache
+        uses: actions/cache/restore@v4
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}-${{ github.run_id }}
+
       - name: Set up Sauce Labs tunnel
         uses: saucelabs/[email protected]
         with:
@@ -91,19 +195,16 @@ jobs:
           mkdir -p ~/.vaadin/
           echo '{"username":"'`echo $TB_LICENSE | cut -d / -f1`'","proKey":"'`echo $TB_LICENSE | cut -d / -f2`'"}' > ~/.vaadin/proKey
 
-      - name: Build with Maven
-        run: |
-          mvn clean install -DskipTests -B
-
-      - name: Run Tests and Generate Javadoc
+      - name: Run Integration Tests
         env:
           SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }}
           SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }}
           SAUCE_TUNNEL_ID: ${{ github.run_id }}-${{ github.run_number }}
         run: |
-          mvn javadoc:javadoc verify \
+          mvn verify \
+            -pl ${{ matrix.module }} -am \
             -P validation \
-            -Dtestbench.javadocs \
+            -Dsurefire.skip=true \
             -Dsystem.com.vaadin.testbench.Parameters.testsInParallel=5 \
             -Dsystem.com.vaadin.testbench.Parameters.maxAttempts=2 \
             -Dcom.vaadin.testbench.Parameters.hubHostname=localhost \
@@ -117,37 +218,34 @@ jobs:
         if: failure()
         uses: actions/upload-artifact@v4
         with:
-          name: error-screenshots-${{ github.run_id }}
+          name: error-screenshots-${{ matrix.name }}-${{ github.run_id }}
           path: |
             **/error-screenshots/**
           retention-days: 7
-      
+
       - name: Upload test reports on failure
         if: failure()
         uses: actions/upload-artifact@v4
         with:
-          name: test-reports-${{ github.run_id }}
+          name: integration-test-reports-${{ matrix.name }}-${{ github.run_id }}
           path: |
-            **/target/surefire-reports/
             **/target/failsafe-reports/
           retention-days: 7
 
       - name: Upload test results
         if: always()
         uses: actions/upload-artifact@v4
         with:
-          name: test-results-${{ github.run_id }}
+          name: integration-test-results-${{ matrix.name }}-${{ github.run_id }}
           path: |
-            **/target/surefire-reports/TEST-*.xml
             **/target/failsafe-reports/TEST-*.xml
           retention-days: 7
 
-      - name: Publish test results
+      - name: Publish integration test results
         if: always()
         uses: EnricoMi/publish-unit-test-result-action@v2
         with:
           files: |
-            **/target/surefire-reports/TEST-*.xml
             **/target/failsafe-reports/TEST-*.xml
-          check_name: Test Results
+          check_name: Integration Test Results (${{ matrix.name }})
           comment_mode: failures