This repository was archived by the owner on Jan 25, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathindex.html
More file actions
161 lines (127 loc) · 5.7 KB
/
Copy pathindex.html
File metadata and controls
161 lines (127 loc) · 5.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8">
<title>Oh My Code Review! a journey with Gerrit</title>
<meta name="description" content="A code review tool based on git">
<meta name="author" content="Hakim El Hattab">
<meta name="apple-mobile-web-app-capable" content="yes" />
<meta name="apple-mobile-web-app-status-bar-style" content="black-translucent" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no">
<link rel="stylesheet" href="css/reveal.min.css">
<link rel="stylesheet" href="css/theme/default.css" id="theme">
<!-- For syntax highlighting -->
<link rel="stylesheet" href="lib/css/zenburn.css">
<!-- If the query includes 'print-pdf', use the PDF print sheet -->
<script>
document.write( '<link rel="stylesheet" href="css/print/' + ( window.location.search.match( /print-pdf/gi ) ? 'pdf' : 'paper' ) + '.css" type="text/css" media="print">' );
</script>
<!--[if lt IE 9]>
<script src="lib/js/html5shiv.js"></script>
<![endif]-->
</head>
<body>
<div class="reveal">
<!-- Any section element inside of this container is displayed as a slide -->
<div class="slides">
<section>
<h1>Oh My Code Review!</h1>
<h3>A journey with Gerrit</h3>
<p>
<small><a href="mailto:manuel.vacelet_at_enalean.com">Manuel Vacelet</a> / <a href="http://twitter.com/vaceletm">@vaceletm</a></small>
</p>
</section>
<section>
<h1>Why to review code?</h1>
<img src='img/code_review_2.jpg' />
</section>
<section>
<h1>Gerrit</h1>
<img src="img/diffy-w200.png" />
<p><small><a href="http://code.google.com/p/gerrit/">http://code.google.com/p/gerrit/</a></small></p>
<ul>
<li>Comes from Android project</li>
<li>Git only</li>
<li>users: Eclipse, QT, Mediawiki, Sony, Motorola, Google, SAP, ...</li>
</ul>
</section>
<section>
<h1>Gerrit workflow</h1>
<img src="img/gerrit_workflow.png" />
</section>
<section>
<h1>Reviews dashboard</h1>
<img src="img/open.png" />
</section>
<section>
<h1>One review</h1>
<img src="img/patchset.png" />
</section>
<section>
<h1>Patch</h1>
<img src="img/patch.png" />
</section>
<section>
<h1>Diff, comments</h1>
<img src="img/diff.png" />
</section>
<section>
<h1>Push for review</h1>
<pre><code>git push ssh://vaceletm@gerrit.tuleap.net:29418 HEAD:refs/for/master</code></pre>
<ul>
<li>One commit == One review</li>
<li>Shape your commits (history rewriting!)</li>
</ul>
</section>
<section>
<h1>Access control</h1>
<img src="img/access.png" />
</section>
<section>
<h1>General comments</h1>
<ul>
<li>Powerful (access, rules)</li>
<li>2.6 + JGit: more efficient than raw access</li>
<li>High learning curve</li>
</ul>
</section>
<section>
<h1>Questions?</h1>
<p>PS: Enalean is hiring!</p>
</section>
<section>
<h1>Credits</h1>
<ul>
<li><a href="http://www.eclipsecon.org/2013/node/1218">It's all about feedback - code review as a great tool in the agile toolbox</a></li>
<li><a href="http://www.eclipsecon.org/2013/node/1129">Scaling Up JGit</a></li>
<li><a href="http://www.eclipsecon.org/2013/node/1130">Deploying Gerrit Code Review</a></li>
</ul>
</section>
</div>
</div>
<script src="lib/js/head.min.js"></script>
<script src="js/reveal.min.js"></script>
<script>
// Full list of configuration options available here:
// https://github.com/hakimel/reveal.js#configuration
Reveal.initialize({
controls: true,
progress: true,
history: true,
center: true,
theme: Reveal.getQueryHash().theme, // available themes are in /css/theme
transition: Reveal.getQueryHash().transition || 'default', // default/cube/page/concave/zoom/linear/fade/none
// Optional libraries used to extend on reveal.js
dependencies: [
{ src: 'lib/js/classList.js', condition: function() { return !document.body.classList; } },
{ src: 'plugin/markdown/showdown.js', condition: function() { return !!document.querySelector( '[data-markdown]' ); } },
{ src: 'plugin/markdown/markdown.js', condition: function() { return !!document.querySelector( '[data-markdown]' ); } },
{ src: 'plugin/highlight/highlight.js', async: true, callback: function() { hljs.initHighlightingOnLoad(); } },
{ src: 'plugin/zoom-js/zoom.js', async: true, condition: function() { return !!document.body.classList; } },
{ src: 'plugin/notes/notes.js', async: true, condition: function() { return !!document.body.classList; } }
// { src: 'plugin/remotes/remotes.js', async: true, condition: function() { return !!document.body.classList; } }
]
});
</script>
</body>
</html>