fix(service-discovery): drain bootstrap futures on shutdown (#2823)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Vlado Pajić <vlado@brrrrr.at>

Author: 2 people

libp2p/protocols/service_discovery.nim

@@ -173,28 +173,28 @@ method stop*(disco: ServiceDiscovery) {.async: (raises: []).} =
 
   # stops the advertiser maintenance loop before draining advertiser tasks, 
   # so shutdown cannot spawn new registration work while cleanup is running
-  if not disco.advertiserMaintenanceLoop.isNil():
+  if not disco.advertiserMaintenanceLoop.isNil:
     await disco.advertiserMaintenanceLoop.cancelAndWait()
     disco.advertiserMaintenanceLoop = nil
 
   await disco.advertiser.clear()
 
-  disco.serviceBootstrapFuts.cancelSoon()
-  disco.serviceBootstrapFuts = @[]
+  let serviceBootstrapFuts = move disco.serviceBootstrapFuts
+  await noCancel serviceBootstrapFuts.cancelAndWait()
 
-  if not disco.selfSignedPeerRecordLoop.isNil():
-    disco.selfSignedPeerRecordLoop.cancelSoon()
+  if not disco.selfSignedPeerRecordLoop.isNil:
+    await disco.selfSignedPeerRecordLoop.cancelAndWait()
     disco.selfSignedPeerRecordLoop = nil
 
-  if not disco.pruneExpiredAdsLoop.isNil():
-    disco.pruneExpiredAdsLoop.cancelSoon()
+  if not disco.pruneExpiredAdsLoop.isNil:
+    await disco.pruneExpiredAdsLoop.cancelAndWait()
     disco.pruneExpiredAdsLoop = nil
 
-  if not disco.refreshServiceTablesLoop.isNil():
-    disco.refreshServiceTablesLoop.cancelSoon()
+  if not disco.refreshServiceTablesLoop.isNil:
+    await disco.refreshServiceTablesLoop.cancelAndWait()
     disco.refreshServiceTablesLoop = nil
 
-  if not disco.localRegistrationLoop.isNil():
+  if not disco.localRegistrationLoop.isNil:
     await disco.localRegistrationLoop.cancelAndWait()
     disco.localRegistrationLoop = nil