Skip to content

Commit 7530d57

Browse files
committed
fix: code review
1 parent d7f3287 commit 7530d57

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

lsquic.nimble

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
packageName = "lsquic"
2-
version = "0.6.0"
2+
version = "0.5.6"
33
author = "Status Research & Development GmbH"
44
description = "Nim wrapper around the lsquic library"
55
license = "MIT"

lsquic/stream.nim

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,10 @@ template raiseIfWriteReset(stream: Stream) =
133133
if stream.writeResetByPeer():
134134
raise stream.newStreamResetError("stream write")
135135

136+
template processWhenAvailable(stream: Stream) =
137+
if not isNil(stream.doProcess):
138+
stream.doProcess()
139+
136140
proc requestClose(stream: Stream): bool {.raises: [].} =
137141
if stream.closedByEngine or stream.quicStream.isNil or stream.closeRequested:
138142
return true
@@ -142,15 +146,15 @@ proc requestClose(stream: Stream): bool {.raises: [].} =
142146
if ret != 0:
143147
let closeErrno = errno
144148
if closeErrno == EBADF:
145-
stream.doProcess()
149+
stream.processWhenAvailable()
146150
return true
147151

148152
stream.closeRequested = false
149153
trace "could not close stream",
150154
streamId = lsquic_stream_id(stream.quicStream), errno = closeErrno
151155
return false
152156

153-
stream.doProcess()
157+
stream.processWhenAvailable()
154158
true
155159

156160
proc closeIfDone*(stream: Stream): bool {.raises: [].} =

0 commit comments

Comments
 (0)