refactor: use IdSecret for seeded_keygen

Author: vinhtc27

rln-wasm/src/wasm_utils.rs

@@ -252,7 +252,7 @@ impl Identity {
         let seed_vec = seed.to_vec();
         let (identity_secret, id_commitment) = seeded_keygen(&seed_vec);
         Identity {
-            identity_secret,
+            identity_secret: *identity_secret,
             id_commitment,
         }
     }

rln/src/ffi/ffi_utils.rs

@@ -371,7 +371,7 @@ pub fn ffi_key_gen() -> repr_c::Vec<CFr> {
 #[ffi_export]
 pub fn ffi_seeded_key_gen(seed: &repr_c::Vec<u8>) -> repr_c::Vec<CFr> {
     let (identity_secret, id_commitment) = seeded_keygen(seed);
-    vec![CFr(identity_secret), CFr(id_commitment)].into()
+    vec![CFr(*identity_secret), CFr(id_commitment)].into()
 }
 
 // ExtendedIdentity

rln/src/protocol/keygen.rs

@@ -44,7 +44,7 @@ pub fn extended_keygen() -> (Fr, Fr, Fr, Fr) {
 ///
 /// Uses ChaCha20 RNG seeded with Keccak-256 hash of the input.
 /// Returns `(identity_secret, id_commitment)`. Same input always produces the same identity.
-pub fn seeded_keygen(signal: &[u8]) -> (Fr, Fr) {
+pub fn seeded_keygen(signal: &[u8]) -> (IdSecret, Fr) {
     // ChaCha20 requires a seed of exactly 32 bytes.
     // We first hash the input seed signal to a 32 bytes array and pass this as seed to ChaCha20
     let mut seed = [0; 32];
@@ -53,7 +53,7 @@ pub fn seeded_keygen(signal: &[u8]) -> (Fr, Fr) {
     hasher.finalize(&mut seed);
 
     let mut rng = ChaCha20Rng::from_seed(seed);
-    let identity_secret = Fr::rand(&mut rng);
+    let identity_secret = IdSecret::rand(&mut rng);
     let id_commitment = poseidon_hash_secret(&identity_secret);
     (identity_secret, id_commitment)
 }

rln/tests/keygen.rs

@@ -36,7 +36,7 @@ mod test {
             .unwrap(),
         );
 
-        assert_eq!(identity_secret, expected_identity_secret_seed_phrase);
+        assert_eq!(*identity_secret, expected_identity_secret_seed_phrase);
         assert_eq!(id_commitment, expected_id_commitment_seed_phrase);
 
         // Generate identity pair using a byte array
@@ -59,13 +59,13 @@ mod test {
             .unwrap(),
         );
 
-        assert_eq!(identity_secret, expected_identity_secret_seed_bytes);
+        assert_eq!(*identity_secret, expected_identity_secret_seed_bytes);
         assert_eq!(id_commitment, expected_id_commitment_seed_bytes);
 
         // We check again if the identity pair generated with the same seed phrase corresponds to the previously generated one
         let (identity_secret, id_commitment) = seeded_keygen(seed_phrase.as_bytes());
 
-        assert_eq!(identity_secret, expected_identity_secret_seed_phrase);
+        assert_eq!(*identity_secret, expected_identity_secret_seed_phrase);
         assert_eq!(id_commitment, expected_id_commitment_seed_phrase);
     }