chore: add more TODO(PR12) [skip-ci]

Author: vinhtc27

rln-wasm/src/wasm_utils.rs

@@ -242,6 +242,7 @@ impl Identity {
     pub fn generate() -> Identity {
         let (identity_secret, id_commitment) = keygen();
         Identity {
+            // TODO(PR12): Leaking secret here, consider using a more secure approach to handle secrets in WASM.
             identity_secret: *identity_secret,
             id_commitment,
         }
@@ -252,6 +253,7 @@ impl Identity {
         let seed_vec = seed.to_vec();
         let (identity_secret, id_commitment) = seeded_keygen(&seed_vec);
         Identity {
+            // TODO(PR12): Leaking secret here, consider using a more secure approach to handle secrets in WASM.
             identity_secret: *identity_secret,
             id_commitment,
         }

rln/src/ffi/ffi_utils.rs

@@ -365,12 +365,14 @@ pub fn ffi_poseidon_hash_pair(a: &CFr, b: &CFr) -> repr_c::Box<CFr> {
 #[ffi_export]
 pub fn ffi_key_gen() -> repr_c::Vec<CFr> {
     let (identity_secret, id_commitment) = keygen();
+    // TODO(PR12): Leaking secret here, consider using a more secure approach to handle secrets in FFI.
     vec![CFr(*identity_secret), CFr(id_commitment)].into()
 }
 
 #[ffi_export]
 pub fn ffi_seeded_key_gen(seed: &repr_c::Vec<u8>) -> repr_c::Vec<CFr> {
     let (identity_secret, id_commitment) = seeded_keygen(seed);
+    // TODO(PR12): Leaking secret here, consider using a more secure approach to handle secrets in FFI.
     vec![CFr(*identity_secret), CFr(id_commitment)].into()
 }
 

rln/src/hashers.rs

@@ -11,7 +11,7 @@ use crate::circuit::Fr;
 
 /// These indexed constants hardcode the supported round parameters tuples (t, RF, RN, SKIP_MATRICES) for the Bn254 scalar field.
 /// SKIP_MATRICES is the index of the randomly generated secure MDS matrix.
-/// TODO: generate these parameters
+/// TODO: Generate these parameters
 const ROUND_PARAMS: [(usize, usize, usize, usize); 8] = [
     (2, 8, 56, 0),
     (3, 8, 57, 0),

rln/src/pm_tree.rs

@@ -18,6 +18,7 @@ use crate::hashers::PoseidonHash;
 /// The key used to store the metadata in database.
 const METADATA_KEY: [u8; 8] = *b"metadata";
 
+//TODO: Export this constant from pmtree crate instead of hardcoding it here.
 /// Maximum tree depth, limited by `pmtree` crate.
 const MAX_DEPTH: usize = 31;
 
@@ -213,7 +214,7 @@ impl<D, H> ZerokitMerkleTree for PmTree<D, H>
 where
     D: Database,
     D::Config: PmTreeBackendConfig,
-    // TODO: unify the two hasher traits (utils `ZerokitHasher` + pmtree `Hasher`).
+    // TODO: Unify the two hasher traits (utils `ZerokitHasher` + pmtree `Hasher`).
     H: ZerokitHasher + Hasher<Fr = FrOf<H>>,
 {
     type Proof = PmTreeProof<H>;

utils/src/poseidon/poseidon_hash.rs

@@ -26,7 +26,7 @@ impl<F: PrimeField> Poseidon<F> {
     // poseidon_params is a vector containing tuples (t, RF, RP, skip_matrices)
     // where: t is the rate (input length + 1), RF is the number of full rounds, RP is the number of partial rounds
     // and skip_matrices is a (temporary) parameter used to generate secure MDS matrices (see comments in the description of find_poseidon_ark_and_mds)
-    // TODO: implement automatic generation of round parameters
+    // TODO: Implement automatic generation of round parameters
     pub fn from(poseidon_params: &[(usize, usize, usize, usize)]) -> Self {
         let mut read_params = Vec::<RoundParameters<F>>::with_capacity(poseidon_params.len());