Skip to content

Commit bbb6ef6

Browse files
refactor: remove commented-out dead code and orphaned browse handler
Drop two commented-out helper functions in log_sanitizer, an abandoned summary_line variant in pipeline, and the disabled browse-video wiring in subtitle_workspace along with its now-unused _browse_for_video_file method and QFileDialog import. Aligns with the repo's no-dead-code comment rules.
1 parent a6c7ad3 commit bbb6ef6

3 files changed

Lines changed: 1 addition & 37 deletions

File tree

src/subsearch/core/pipeline.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,8 +284,7 @@ def finish_notification(self) -> None:
284284
downloaded_count, total_count = self._count_downloaded_subtitles()
285285
succeeded = downloaded_count > 0
286286
if succeeded:
287-
# summary_line = f"Downloaded: {downloaded_count}/{total_count}"
288-
summary_line = f"All tasks done!"
287+
summary_line = "All tasks done!"
289288
else:
290289
summary_line = self._failure_reason(total_count)
291290
elapsed_summary = f"Finished in {self._elapsed()} seconds"

src/subsearch/runtime/logging/log_sanitizer.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,6 @@
55

66
from subsearch.runtime.config import COMPUTER_NAME, FILE_PATHS, GUID
77

8-
# def _redact_literal(secret: str, show: int = 0,) -> str:
9-
# # * •
10-
# visible_prefix = secret[:show]
11-
# hidden_length = max(len(secret) - show, 1)
12-
# return f"{visible_prefix}{'*' * hidden_length}"
13-
14-
15-
# def _redact(match: re.Match[str]) -> str:
16-
# return _redact_literal(match.group(0))
17-
18-
198
# matches IPv4 addresses e.g. "192.168.1.1" matches, "1234.1.1.1" does not
209
IP_ADDRESS_PATTERN = re.compile(r"\b\d{1,3}(?:\.\d{1,3}){3}\b")
2110
# matches email addresses e.g. "user.name+tag@sub.domain.org"

src/subsearch/ui/cards/subtitle_workspace.py

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
)
1414
from PySide6.QtSvg import QSvgRenderer
1515
from PySide6.QtWidgets import (
16-
QFileDialog,
1716
QHBoxLayout,
1817
QListWidgetItem,
1918
QSplitter,
@@ -259,17 +258,13 @@ def _build_video_file_section(self) -> None:
259258
self._filename_edit.returnPressed.connect(self._on_search_clicked)
260259
self._filename_edit.button_clicked.connect(self._on_search_clicked)
261260

262-
# browse_video = CaptionedToolButton("Browse", icon=lucide_qicon(LucideIcon.FOLDER_OPEN, TEXT_COLOR), parent=self)
263-
# browse_video.clicked.connect(self._browse_for_video_file)
264-
265261
file_row = QHBoxLayout()
266262
file_row.setContentsMargins(SEPARATOR_INSET, 0, SEPARATOR_INSET, 10)
267263
file_row.setSpacing(0)
268264
side_stretch = round((1 - SEARCH_BAR_WIDTH_FRACTION) * 100 / 2)
269265
file_row.addStretch(side_stretch)
270266
file_row.addWidget(self._filename_edit, stretch=round(SEARCH_BAR_WIDTH_FRACTION * 100))
271267
file_row.addStretch(side_stretch)
272-
# file_row.addWidget(TrailingButtonArea([browse_video], parent=self))
273268
section_layout.addLayout(file_row)
274269

275270
def _on_search_clicked(self) -> None:
@@ -430,25 +425,6 @@ def select_dropped_video(self, file_path: Path) -> None:
430425
self._committed_filename = file_path.name
431426
self._video_file_service.select_video(file_path)
432427

433-
def _browse_for_video_file(self) -> None:
434-
from subsearch.runtime.config import DEFAULT_CONFIG
435-
436-
extensions = DEFAULT_CONFIG.get("shell_integration", {}).get("file_extensions", {})
437-
enabled_exts = [ext for ext, enabled in extensions.items() if enabled]
438-
filter_string = "Video files ({})".format(" ".join(f"*.{ext}" for ext in enabled_exts))
439-
selected, _ = QFileDialog.getOpenFileName(
440-
self.window(),
441-
"Select video file",
442-
str(WORKSPACE.file_directory) if WORKSPACE.file_directory != Path("") else "",
443-
filter_string,
444-
)
445-
if not selected:
446-
return
447-
selected_path = Path(selected)
448-
self._filename_edit.setText(selected_path.name)
449-
self._committed_filename = selected_path.name
450-
self._video_file_service.select_video(selected_path)
451-
452428

453429
class SubtitleCard(SettingsCard):
454430
search_text_changed = Signal(str)

0 commit comments

Comments
 (0)