Skip to content

Commit bc8f4ba

Browse files
fix(ci): validate gate finds ready PRs and always runs on dispatch
- Remove --draft filter from open_release_pr so validation works against both draft and ready-for-review release PRs - On workflow_dispatch with no open PR, fail immediately instead of silently skipping - On workflow_dispatch with a PR, always proceed regardless of src tree hash - Cron path still uses should_validate to skip unchanged src trees
1 parent aa02f2b commit bc8f4ba

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/scripts/actions.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -710,7 +710,6 @@ def open_release_pr(self) -> str | None:
710710
"dev",
711711
"--state",
712712
"open",
713-
"--draft",
714713
"--label",
715714
"release",
716715
"--json",

.github/workflows/scripts/jobs.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -343,15 +343,16 @@ def run(self) -> None:
343343
validation = ReleaseValidation()
344344
step_summary = StepSummary()
345345

346+
forced = os.environ["GITHUB_EVENT_NAME"] == "workflow_dispatch"
347+
346348
number = validation.open_release_pr()
347349
if number is None:
350+
if forced:
351+
raise SystemExit("No open release PR found; cannot validate on manual dispatch.")
348352
step_summary.set_output("proceed", "false")
349353
return
350354

351-
event = os.environ["GITHUB_EVENT_NAME"]
352-
forced = event == "workflow_dispatch"
353-
scheduled = event == "schedule"
354-
proceed = forced or (scheduled and validation.should_validate(number))
355+
proceed = forced or validation.should_validate(number)
355356

356357
step_summary.set_output("proceed", "true" if proceed else "false")
357358
step_summary.set_output("pr_number", number)

0 commit comments

Comments
 (0)