Skip to content

Design better connection handling for Connection and Notification stream #36

Description

@relu91

After fdb25ca, we removed the forwarding of errors from ws of a Connection to NotificationStream. This caused a set of problems with users trying to re-subscribe when a Subscription failed. In particular, since the connection error was forwarded before the catch close in the connect function inside notificationStream method, the connection object was not cleanly closed and it started reconnecting without control. Furthermore, it was impossible to invalidate the connection inside the connectionPool because the new connection was created before the clean-up function in the error handler (the error handler cannot be registered before the one that fire the initial error).

In future releases, we should spend time to rethink once again the process of connection control in our API.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions