Skip to content

Commit 6764cf6

Browse files
authored
Dont close pool (#74)
* Don't close the pool This caused failures in prod for us: there are still messages being sent at this point. * Add changeset
1 parent b780b19 commit 6764cf6

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

.changeset/light-tigers-design.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@valtown/deno-http-worker": patch
3+
---
4+
5+
Don't close the pool (bugfix)

src/DenoHTTPWorker.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -337,8 +337,6 @@ class denoHTTPWorker implements DenoHTTPWorker {
337337
forceKill(this.#process.pid!);
338338
}
339339

340-
await this.#pool.close();
341-
342340
fs.rm(this.#socketFile).catch(() => {});
343341
for (const onexit of this.#onexitListeners) {
344342
onexit(code ?? 1, signal ?? "");
@@ -354,7 +352,6 @@ class denoHTTPWorker implements DenoHTTPWorker {
354352
await new Promise<void>((res) => {
355353
this.#process.on("exit", res);
356354
});
357-
await this.#pool.close();
358355
}
359356

360357
async websocket(

0 commit comments

Comments
 (0)