SpaceBeforeParenCheck: fix column offset (#196)

* SpaceBeforeParenCheck: fix column offset

Closes: #195

* Fix SpaceBeforeParens check offsets in tests

---------

Co-authored-by: Colin Kiama <colinkiama@gmail.com>

Author: x1z53

lib/Checks/SpaceBeforeParenCheck.vala

@@ -32,7 +32,7 @@ public class ValaLint.Checks.SpaceBeforeParenCheck : Check {
         foreach (ParseResult r in parse_result) {
             if (r.type == ParseType.DEFAULT) {
                 add_regex_mistake ("""[^_\s{\[\(\)!~]\(""", _("Expected space before paren"), r,
-                                   ref mistake_list, 1, 1);
+                                   ref mistake_list, 1, 0);
             }
         }
     }

test/ContentTest.vala

@@ -59,7 +59,7 @@ class ContentTest : GLib.Object {
         var general_warnings = CheckTest.FileTestMistakeList ();
         general_warnings.add ("using-directive", 3);
         general_warnings.add ("naming-convention", 3);
-        general_warnings.add ("space-before-paren", 2, 26, 27);
+        general_warnings.add ("space-before-paren", 2, 25, 26);
         general_warnings.add ("note", 1, 21, 25, "TODO");
         general_warnings.add ("note", 1, 21, 38, "TODO: Lorem ipsum");
         general_warnings.add ("double-spaces", 2, 25, 27);
@@ -105,9 +105,9 @@ class ContentTest : GLib.Object {
         check_contents_for_mistake (CheckTest.get_test_file ("note-check.vala"), note_warnings);
 
         var space_before_paren_warnings = CheckTest.FileTestMistakeList ();
-        space_before_paren_warnings.add ("space-before-paren", 4, 9, 10);
-        space_before_paren_warnings.add ("no-space", 5, 14, 15);
-        space_before_paren_warnings.add ("space-before-paren", 0, 14, 15);
+        space_before_paren_warnings.add ("space-before-paren", 4, 8, 9);
+        space_before_paren_warnings.add ("space-before-paren", 5, 13, 14);
+        space_before_paren_warnings.add ("no-space", 0, 14, 15);
         space_before_paren_warnings.add ("no-space", 0, 17, 18);
         space_before_paren_warnings.add ("no-space", 0, 18, 19);
         check_contents_for_mistake (CheckTest.get_test_file ("space-before-paren-check.vala"),

test/FileTest.vala

@@ -54,7 +54,7 @@ class FileTest : GLib.Object {
         var general_warnings = CheckTest.FileTestMistakeList ();
         general_warnings.add ("using-directive", 3);
         general_warnings.add ("naming-convention", 3);
-        general_warnings.add ("space-before-paren", 2, 26, 27);
+        general_warnings.add ("space-before-paren", 2, 25, 26);
         general_warnings.add ("note", 1, 21, 25, "TODO");
         general_warnings.add ("note", 1, 21, 38, "TODO: Lorem ipsum");
         general_warnings.add ("double-spaces", 2, 25, 27);
@@ -100,9 +100,9 @@ class FileTest : GLib.Object {
        check_file_for_mistake (CheckTest.get_test_file ("note-check.vala"), note_warnings);
 
         var space_before_paren_warnings = CheckTest.FileTestMistakeList ();
-        space_before_paren_warnings.add ("space-before-paren", 4, 9, 10);
-        space_before_paren_warnings.add ("no-space", 5, 14, 15);
-        space_before_paren_warnings.add ("space-before-paren", 0, 14, 15);
+        space_before_paren_warnings.add ("space-before-paren", 4, 8, 9);
+        space_before_paren_warnings.add ("space-before-paren", 5, 13, 14);
+        space_before_paren_warnings.add ("no-space", 0, 14, 15);
         space_before_paren_warnings.add ("no-space", 0, 17, 18);
         space_before_paren_warnings.add ("no-space", 0, 18, 19);
        check_file_for_mistake (CheckTest.get_test_file ("space-before-paren-check.vala"),