treat version string parse failures as heartbeat-enabled versions by default (Netflix#444)

Author: saikonen

services/metadata_service/tests/unit_tests/task_test.py

@@ -25,6 +25,7 @@
     (["metaflow_version:2.12.24+inconsequential+trailing-string"], True),
     (["metaflow_version:2.12.24.break"], True),
     (["metaflow_version:3"], True),
+    (["metaflow_version:custom-1"], True),
 ]
 
 

services/utils/__init__.py

@@ -150,18 +150,20 @@ def has_heartbeat_capable_version_tag(system_tags):
     """Check client version tag whether it is known to support heartbeats or not"""
     try:
         # only parse for the major.minor.patch version and disregard any trailing bits that might cause issues with comparison.
-        version_tag = [tag for tag in system_tags if tag.startswith('metaflow_version:')][0]
+        version_tags = [tag for tag in system_tags if tag.startswith('metaflow_version:')]
+        if not version_tags:
+            return False
         # match versions: major | major.minor | major.minor.patch
-        ver_string = re.match(r"(0|\d+)(\.(0|\d+))*", version_tag[len("metaflow_version:"):])[0]
-        print(ver_string)
+        ver_string = re.match(r"(0|\d+)(\.(0|\d+))*", version_tags[0].lstrip("metaflow_version:"))[0]
         version = parse(ver_string)
 
         if version >= Version("1") and version < Version("2"):
             return version >= Version("1.14.0")
 
         return version >= Version("2.2.12")
     except Exception:
-        return False
+        # Treat non-standard versions as heartbeat-enabled by default
+        return True
 
 # Database configuration helper
 # Prioritizes DSN string over individual connection arguments (host,user,...)