You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here are a few more thoughts about how we will implement a pre-commit hook:
Have a less verbose logging scheme and only show what is causing the issue
Can throw a nonzero exit code so pre-commit can fail when discovering secrets.We already support this
Have a way to dump the findings to JSON
Can point out what is causing the pre-commit fail. For example, if we discover an AWS credential, it would be nice to show what file, pattern, and regex match is causing the issue. Related to Unable to print the finding #61
The PC hook should also allow filtering signatures we need (which we already have) and specifying signatures we want to ignore (which we don't have).
Activity
inverse commentedon Mar 8, 2023
Sounds like a good idea!
inverse commentedon Mar 8, 2023
Docs here: https://pre-commit.com/#new-hooks
Example: https://github.com/PyCQA/isort/blob/main/.pre-commit-hooks.yaml
valayDave commentedon Mar 9, 2023
Here are a few more thoughts about how we will implement a pre-commit hook: