Timeline cleanup runs twice on overlapping orphan lists, producing WARNING for each duplicate

[TheThinkingHome]

Checklist

• I'm running the newest version of LLM Vision https://github.com/valentinfrlch/ha-llmvision/releases/latest
• I have enabled debug logging for the integration.
• I have filled out the issue template to the best of my ability.
• This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
• This is a bug and not a feature request.
• I have searched open issues for my problem.

Describe the issue

On every Home Assistant restart, the LLMVision timeline cleanup logs a WARNING for every snapshot file it tries to remove that is no longer present on disk. After this morning's restart with debug logging enabled, I can also see that the cleanup runs over the same file path more than once in a single pass: the first call succeeds and removes the file, the second call then fails with FileNotFoundError because the file is already gone. Last night's 03:32 restart produced 51 of these warnings in 74 ms; this morning's manual restart produced one warning, but the same duplicate-removal pattern is visible in the INFO lines that surround it.

The cleanup is idempotent by design (the goal is "file gone"), so a second pass over an already-deleted file is a satisfied precondition, not a failure. Treating it as a WARNING also makes legitimate cleanup problems harder to spot.

Suggested fix, either or both: deduplicate the orphan list before iterating, and wrap os.remove in a FileNotFoundError catch so a missing file is silent (or DEBUG-level) rather than a warning.

pythontry:
os.remove(path)
except FileNotFoundError:
pass
except OSError as e:
_LOGGER.warning("[CLEANUP] Failed to remove %s: %s", path, e)

Reproduction steps

1. Use LLMVision to analyse snapshots over time, allowing the timeline database to accumulate tracked file paths.
2. Allow some snapshot files to be removed from /media/llmvision/snapshots/ (by retention policy, manual cleanup, or the host restart cycle).
3. Restart Home Assistant.
4. In the HA log immediately after restart, observe a cluster of WARNING lines from custom_components.llmvision.timeline, one for each file the timeline expected to find but did not.

Debug logs

The full debug log dump leaks a substantial amount of personal data (face recognition training image paths and memory_strings with the names of household members, the dog, our neighbour, and other named contacts). I'm including the relevant log lines below rather than the raw dump. If more context is needed, I can capture and redact additional logs tomorrow morning after the next overnight restart.

Last night's 03:32 restart (debug logging not yet enabled, WARNING lines only)

2026-06-17 03:32:08.911 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/dbe49023-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/dbe49023-0.jpg'
2026-06-17 03:32:08.913 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/9c2582ef-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/9c2582ef-0.jpg'
2026-06-17 03:32:08.914 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/0ffdd0e5-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/0ffdd0e5-0.jpg'
2026-06-17 03:32:08.915 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/e5744fc4-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/e5744fc4-0.jpg'
2026-06-17 03:32:08.916 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/fba8e53b-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/fba8e53b-0.jpg'
2026-06-17 03:32:08.917 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/8bebfa1d-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/8bebfa1d-0.jpg'
2026-06-17 03:32:08.921 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/9fd90e64-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/9fd90e64-0.jpg'
2026-06-17 03:32:08.922 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/e9d7d9f8-5.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/e9d7d9f8-5.jpg'
2026-06-17 03:32:08.923 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/a8b1e7a6-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/a8b1e7a6-0.jpg'
2026-06-17 03:32:08.924 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/a830ee07-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/a830ee07-0.jpg'
2026-06-17 03:32:08.926 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/e000ea60-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/e000ea60-0.jpg'
2026-06-17 03:32:08.926 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/6700ad02-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/6700ad02-0.jpg'
2026-06-17 03:32:08.927 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/94232eb7-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/94232eb7-0.jpg'
2026-06-17 03:32:08.928 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/f8c5c3f3-5.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/f8c5c3f3-5.jpg'
2026-06-17 03:32:08.929 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/d885a29b-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/d885a29b-0.jpg'
2026-06-17 03:32:08.930 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/e906280b-4.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/e906280b-4.jpg'
2026-06-17 03:32:08.931 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/8004e879-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/8004e879-0.jpg'
2026-06-17 03:32:08.932 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/70b3f13d-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/70b3f13d-0.jpg'
2026-06-17 03:32:08.933 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/51db3102-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/51db3102-0.jpg'
2026-06-17 03:32:08.934 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/2970def6-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/2970def6-0.jpg'
2026-06-17 03:32:08.935 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/421140bb-3.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/421140bb-3.jpg'
2026-06-17 03:32:08.936 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/2b5bda49-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/2b5bda49-0.jpg'
2026-06-17 03:32:08.937 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/63fe5cc0-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/63fe5cc0-0.jpg'
2026-06-17 03:32:08.938 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/1efba5d2-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/1efba5d2-0.jpg'
2026-06-17 03:32:08.939 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/8e241ec9-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/8e241ec9-0.jpg'
2026-06-17 03:32:08.940 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/3955d733-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/3955d733-0.jpg'
2026-06-17 03:32:08.941 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/9a88b08d-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/9a88b08d-0.jpg'
2026-06-17 03:32:08.942 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/96c80499-3.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/96c80499-3.jpg'
2026-06-17 03:32:08.943 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/767979f2-6.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/767979f2-6.jpg'
2026-06-17 03:32:08.943 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/ed404afc-4.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/ed404afc-4.jpg'
2026-06-17 03:32:08.945 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/45face67-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/45face67-0.jpg'
2026-06-17 03:32:08.946 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/8d49a9d6-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/8d49a9d6-0.jpg'
2026-06-17 03:32:08.947 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/703d45fc-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/703d45fc-0.jpg'
2026-06-17 03:32:08.948 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/79ac9a91-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/79ac9a91-0.jpg'
2026-06-17 03:32:08.950 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/06ee97bd-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/06ee97bd-0.jpg'
2026-06-17 03:32:08.952 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/e92ecbbe-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/e92ecbbe-0.jpg'
2026-06-17 03:32:08.953 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/c33388e8-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/c33388e8-0.jpg'
2026-06-17 03:32:08.954 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/5503b17c-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/5503b17c-0.jpg'
2026-06-17 03:32:08.956 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/47703227-6.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/47703227-6.jpg'
2026-06-17 03:32:08.959 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/95ca547b-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/95ca547b-0.jpg'
2026-06-17 03:32:08.960 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/2b81c334-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/2b81c334-0.jpg'
2026-06-17 03:32:08.966 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/32d0aab6-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/32d0aab6-0.jpg'
2026-06-17 03:32:08.967 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/fb4fe58a-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/fb4fe58a-0.jpg'
2026-06-17 03:32:08.968 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/67df2697-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/67df2697-0.jpg'
2026-06-17 03:32:08.969 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/eb640c45-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/eb640c45-0.jpg'
2026-06-17 03:32:08.971 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/d67f0f5c-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/d67f0f5c-0.jpg'
2026-06-17 03:32:08.973 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/1d5254c4-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/1d5254c4-0.jpg'
2026-06-17 03:32:08.973 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/0c117e7f-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/0c117e7f-0.jpg'
2026-06-17 03:32:08.975 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/5ca2724b-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/5ca2724b-0.jpg'
2026-06-17 03:32:08.976 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/b1aa313c-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/b1aa313c-0.jpg'
2026-06-17 03:32:08.985 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/07f81ad5-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/07f81ad5-0.jpg'

51 WARNING lines in 74 ms.

This morning's 08:04 restart (debug logging enabled, showing the duplicate-pass)

2026-06-17 08:04:07.592 INFO (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Removing unlinked snapshot: 8f1987fa-0.jpg
2026-06-17 08:04:07.593 INFO (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Removing unlinked snapshot: cf98f79e-0.jpg
2026-06-17 08:04:07.594 INFO (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Removing unlinked snapshot: cf98f79e-0.jpg
2026-06-17 08:04:07.594 DEBUG (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Removed 1 orphaned snapshot(s)
2026-06-17 08:04:07.594 WARNING (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Failed to remove /media/llmvision/snapshots/cf98f79e-0.jpg: [Errno 2] No such file or directory: '/media/llmvision/snapshots/cf98f79e-0.jpg'
2026-06-17 08:04:07.594 DEBUG (MainThread) [custom_components.llmvision.timeline] [CLEANUP] Removed 1 orphaned snapshot(s)

cf98f79e-0.jpg is listed twice as an unlinked snapshot to remove. The first removal succeeds (no error). The second attempt fails with FileNotFoundError because the file is already gone. Two [CLEANUP] Removed 1 orphaned snapshot(s) debug lines confirm that the cleanup is running over the same set twice in a single startup pass.

This morning's restart only orphaned one file, so only one warning surfaced. Last night's 03:32 restart followed the daily retention sweep, which is why 51 warnings appeared. If more logs would help diagnose, I can capture and redact tomorrow morning's 03:30 restart with debug logging on.