_

Author: valeratrades

README.md

@@ -2,7 +2,7 @@
 ![Minimum Supported Rust Version](https://img.shields.io/badge/nightly-1.85+-ab6000.svg)
 [<img alt="crates.io" src="https://img.shields.io/crates/v/v_exchanges.svg?color=fc8d62&logo=rust" height="20" style=flat-square>](https://crates.io/crates/v_exchanges)
 [<img alt="docs.rs" src="https://img.shields.io/badge/docs.rs-66c2a5?style=for-the-badge&labelColor=555555&logo=docs.rs&style=flat-square" height="20">](https://docs.rs/v_exchanges)
-![Lines Of Code](https://img.shields.io/badge/LoC-3924-lightblue)
+![Lines Of Code](https://img.shields.io/badge/LoC-3919-lightblue)
 <br>
 [<img alt="ci errors" src="https://img.shields.io/github/actions/workflow/status/valeratrades/v_exchanges/errors.yml?branch=master&style=for-the-badge&style=flat-square&label=errors&labelColor=420d09" height="20">](https://github.com/valeratrades/v_exchanges/actions?query=branch%3Amaster) <!--NB: Won't find it if repo is private-->
 [<img alt="ci warnings" src="https://img.shields.io/github/actions/workflow/status/valeratrades/v_exchanges/warnings.yml?branch=master&style=for-the-badge&style=flat-square&label=warnings&labelColor=d16002" height="20">](https://github.com/valeratrades/v_exchanges/actions?query=branch%3Amaster) <!--NB: Won't find it if repo is private-->

v_exchanges/src/binance/market.rs

@@ -25,14 +25,9 @@ pub async fn klines(client: &v_exchanges_adapters::Client, pair: Pair, tf: Timef
 	});
 	let params = join_params(base_params, range_params);
 
-	let endpoint_prefix = match market {
-		Market::Spot => "/api/v3",
-		Market::Futures => "/fapi/v1",
-		Market::Margin => unimplemented!(),
-	};
-	let base_url: BinanceHttpUrl = match market {
-		Market::Spot => BinanceHttpUrl::Spot,
-		Market::Futures => BinanceHttpUrl::FuturesUsdM,
+	let (endpoint_prefix, base_url) = match market {
+		Market::Spot => ("/api/v3", BinanceHttpUrl::Spot),
+		Market::Futures => ("/fapi/v1", BinanceHttpUrl::FuturesUsdM),
 		Market::Margin => unimplemented!(),
 	};
 
@@ -51,7 +46,7 @@ pub async fn klines(client: &v_exchanges_adapters::Client, pair: Pair, tf: Timef
 					low: k.low,
 					close: k.close,
 				};
-				klines.push_front(Kline {
+				klines.push_back(Kline {
 					open_time: DateTime::from_timestamp_millis(k.open_time).unwrap(),
 					ohlc,
 					volume_quote: k.quote_asset_volume,
@@ -61,7 +56,7 @@ pub async fn klines(client: &v_exchanges_adapters::Client, pair: Pair, tf: Timef
 			}
 			false => match i == r_len - 1 {
 				true => tracing::trace!("Skipped last kline in binance request, as it's incomplete (expected behavior)"),
-				false => tracing::warn!("Skipped kline in binance request, as it's incomplete"),
+				false => tracing::warn!("Skipped a kline in binance request, as it's incomplete"),
 			},
 		}
 	}

v_exchanges/src/binance/mod.rs

@@ -1,4 +1,4 @@
-mod data;
+pub mod data; // interfaced with directly, not through `Exchange` trait, thus must be public.
 mod futures;
 mod market;
 mod spot;

v_exchanges_api_generics/src/http.rs

@@ -278,7 +278,7 @@ impl Default for RequestConfig {
 #[derive(Error, std::fmt::Debug)]
 pub enum RequestError<E, R> {
 	/// An error which occurred while sending a HTTP request.
-	#[error("failed to send reqeust")]
+	#[error("failed to send request")]
 	SendRequest(#[source] reqwest::Error),
 	/// An error which occurred while receiving a HTTP response.
 	#[error("failed to receive response")]