_

Author: valeratrades

examples/binance/market_spot.rs

@@ -9,6 +9,7 @@ async fn main() {
 	v_utils::utils::init_subscriber(v_utils::utils::LogDestination::xdg("v_exchanges"));
 
 	//let m: Market = "Binance/Spot".into(); // would be nice to be able to do it like this, without having to carry around exchange-specific type
+	// Currently if I want to pass around the market struct in my code after initializing it, I have to pass around eg `binance::Market`, which is a ridiculous thing to hardcode into function signatures
 	let m = binance::Market::Spot;
 	let bn = m.client();
 

v_exchanges/src/binance/futures/general.rs

@@ -1,4 +1,3 @@
-use std::collections::HashMap;
 
 use adapters::binance::{BinanceHttpUrl, BinanceOption};
 use chrono::DateTime;

v_exchanges/src/binance/market.rs

@@ -1,6 +1,6 @@
 use std::collections::VecDeque;
 
-use chrono::{DateTime, TimeZone, Utc};
+use chrono::{DateTime, TimeZone as _, Utc};
 //HACK: Methods should be implemented on the central interface struct, following <https://github.com/wisespace-io/binance-rs>.
 use eyre::Result;
 use serde::{Deserialize, Serialize};
@@ -58,7 +58,7 @@ pub async fn klines(client: &v_exchanges_adapters::Client, pair: Pair, tf: Timef
 		Market::Margin => unimplemented!(),
 	};
 
-	let kline_responses: Vec<KlineResponse> = client.get(&format!("{endpoint_prefix}/klines"), &params, [BinanceOption::HttpUrl(base_url)]).await.unwrap();
+	let kline_responses: Vec<KlineResponse> = client.get(&format!("{endpoint_prefix}/klines"), &params, [BinanceOption::HttpUrl(base_url)]).await?;
 
 	let r_len = kline_responses.len();
 	let mut klines = VecDeque::with_capacity(r_len);

v_exchanges/src/binance/mod.rs

@@ -76,4 +76,8 @@ impl crate::core::MarketTrait for Market {
 	fn client(&self) -> Binance {
 		Binance::default()
 	}
+
+	fn fmt_abs(&self) -> String {
+	  format!("Binance/{self}")
+	}
 }

v_exchanges/src/bybit/mod.rs

@@ -25,7 +25,7 @@ impl Exchange for Bybit {
 	}
 
 	async fn exchange_info(&self, m: Self::M) -> Result<ExchangeInfo> {
-	  todo!();
+		todo!();
 	}
 
 	async fn klines(&self, pair: Pair, tf: Timeframe, range: KlinesRequestRange, m: Self::M) -> Result<Klines> {
@@ -74,4 +74,8 @@ impl crate::core::MarketTrait for Market {
 	fn client(&self) -> Bybit {
 		Bybit::default()
 	}
+
+	fn fmt_abs(&self) -> String {
+		format!("Bybit/{self}")
+	}
 }

v_exchanges/src/core.rs

@@ -39,6 +39,8 @@ pub trait Exchange {
 pub trait MarketTrait {
 	type Client: Exchange;
 	fn client(&self) -> Self::Client;
+	fn fmt_abs(&self) -> String;
+	//TODO; require them to impl Display and FromStr
 }
 //TODO!: figure out how can I expose one central `Market` enum, so client doesn't have to bring into the scope `MarketTrait` and deal with the exchange-specific `Market`'s type
 // Maybe [enum_dispatch](<https://docs.rs/enum_dispatch/latest/enum_dispatch/>) crate could help?
@@ -227,6 +229,11 @@ pub struct ExchangeInfo {
 	pub server_time: DateTime<Utc>,
 	pub pairs: HashMap<Pair, PairInfo>,
 }
+impl ExchangeInfo {
+	pub fn usdt_pairs(&self) -> impl Iterator<Item = Pair> {
+		self.pairs.keys().filter(|p| p.is_usdt()).copied()
+	}
+}
 #[derive(Clone, Debug, Default)]
 pub struct PairInfo {
 	pub price_precision: u8,