refactor: _

Author: valeratrades

README.md

@@ -2,7 +2,7 @@
 ![Minimum Supported Rust Version](https://img.shields.io/badge/nightly-1.85+-ab6000.svg)
 [<img alt="crates.io" src="https://img.shields.io/crates/v/v_exchanges.svg?color=fc8d62&logo=rust" height="20" style=flat-square>](https://crates.io/crates/v_exchanges)
 [<img alt="docs.rs" src="https://img.shields.io/badge/docs.rs-66c2a5?style=for-the-badge&labelColor=555555&logo=docs.rs&style=flat-square" height="20">](https://docs.rs/v_exchanges)
-![Lines Of Code](https://img.shields.io/badge/LoC-3736-lightblue)
+![Lines Of Code](https://img.shields.io/badge/LoC-3745-lightblue)
 <br>
 [<img alt="ci errors" src="https://img.shields.io/github/actions/workflow/status/valeratrades/v_exchanges/errors.yml?branch=master&style=for-the-badge&style=flat-square&label=errors&labelColor=420d09" height="20">](https://github.com/valeratrades/v_exchanges/actions?query=branch%3Amaster) <!--NB: Won't find it if repo is private-->
 [<img alt="ci warnings" src="https://img.shields.io/github/actions/workflow/status/valeratrades/v_exchanges/warnings.yml?branch=master&style=for-the-badge&style=flat-square&label=warnings&labelColor=d16002" height="20">](https://github.com/valeratrades/v_exchanges/actions?query=branch%3Amaster) <!--NB: Won't find it if repo is private-->

examples/data.rs

@@ -9,6 +9,6 @@ async fn main() {
 	dbg!(&bvol);
 
 	let bn = Binance::default();
-	let lsr = bn.global_lsr_account(("BTC", "USDT").into(), "5m".into(), 24 * 12 + 1, "Global".into()).await.unwrap();
+	let lsr = bn.lsr(("BTC", "USDT").into(), "5m".into(), 24 * 12 + 1, "Global".into()).await.unwrap();
 	dbg!(&lsr[..2]);
 }

v_exchanges/src/binance/data.rs

@@ -23,7 +23,7 @@ impl From<&str> for LsrWho {
 }
 
 impl Binance {
-	pub async fn global_lsr_account(&self, pair: Pair, tf: Timeframe, limit: u32, who: LsrWho) -> Result<Vec<Lsr>> {
+	pub async fn lsr(&self, pair: Pair, tf: Timeframe, limit: u32, who: LsrWho) -> Result<Vec<Lsr>> {
 		let allowed_range = 1..=500;
 		//TODO!!: add a `limit outside of range` error, generic for all exchanges
 		assert!(allowed_range.contains(&limit));
@@ -58,21 +58,30 @@ pub struct LsrResponse {
 pub struct Lsr {
 	pub time: DateTime<Utc>,
 	pub pair: Pair,
-	pub long: Percent,
-	pub short: Percent,
+	pub p_long: Percent,
 }
+//Q: couldn't decide if `short()` and `long(0` should return `f64` or `Percent`. Postponing the decision.
 impl Lsr {
 	pub fn ratio(&self) -> f64 {
-		*self.long / *self.short
+		*self.p_long / self.short()
+	}
+
+	/// Percentage of short positions
+	pub fn short(&self) -> f64 {
+		1.0 - *self.p_long
+	}
+
+	/// Percentage of long positions. // here only for consistency with `short`
+	pub fn long(&self) -> f64 {
+		*self.p_long
 	}
 }
 impl From<LsrResponse> for Lsr {
 	fn from(r: LsrResponse) -> Self {
 		Self {
 			time: DateTime::from_timestamp_millis(r.timestamp).unwrap(),
 			pair: Pair::from_str(&r.symbol).unwrap(),
-			long: Percent::from_str(&r.long_account).unwrap(),
-			short: Percent::from_str(&r.short_account).unwrap(),
+			p_long: Percent::from_str(&r.long_account).unwrap(),
 		}
 	}
 }

v_exchanges/src/core.rs

@@ -45,12 +45,12 @@ pub trait MarketTrait {
 //TODO!: figure out how can I expose one central `Market` enum, so client doesn't have to bring into the scope `MarketTrait` and deal with the exchange-specific `Market`'s type
 // Maybe [enum_dispatch](<https://docs.rs/enum_dispatch/latest/enum_dispatch/>) crate could help?
 
-//#[derive(Debug, Clone, Copy)]
-//pub enum Market {
-//	Binance(crate::binance::Market),
-//	Bybit(crate::bybit::Market),
-//	//TODO
-//}
+#[derive(Debug, Clone, Copy)]
+pub enum Market {
+	Binance(crate::binance::Market),
+	Bybit(crate::bybit::Market),
+	//TODO
+}
 //
 //impl Default for Market {
 //	fn default() -> Self {